redhat-developer / redhat-developer/vscode-java
java.import.maven.enabled setting not honored
まだ誰も着手していません。
- 主要言語
- TypeScript
- スター
- 2.3k
- フォーク
- 546
- 平均マージ
- 20時間 1分
- マージ済み PR(30日)
- 11
説明
Currently, the "java.import.maven.enabled":false setting requires that the .project, .classpath files and the .settings directory be removed and the Java workspace cleaned before taking effect (see https://github.com/redhat-developer/vscode-java/issues/634#issuecomment-529466893). This is clunky and poorly-documented.
Ideally, setting the "java.import.maven.enabled":false should immediately take effect. Less ideally, there should be clear documentation around the use of this setting to instruct users to clear out the files and clean the workspace.
Truthfully, my use case is to disable the Java language features for one of the folders in my multi-root workspace. This is currently made possible by disabling the import, but one could imagine a world in which this is a different setting, which would take effect immediately.
Environment
- Operating System: Windows 10 1809
- JDK version: 1.8.0_221
- Visual Studio Code version: 1.38.0
- Java extension version: 0.48.0
Steps To Reproduce
- Open a fresh workspace in VS Code
- Open a folder containing a Java project - we'll call this Project1
- The Java extension will immediately import and start compiling the code
- Add another folder containing another Java project to the workspace - we'll call this Project2
- The Java extension will immediately import and start compiling the code
- Restart VS Code
- The Java extension will immediately start compiling the code for both projects
- Edit Project2's VS Code settings ([project2]/.vscode/settings.json) to contain the following:
{ "java.import.gradle.enabled":false, "java.import.maven.enabled":false } - Restart VS Code
- The Java extensions will immediately start compiling the code for both projects
Current Result
Immediately after setting the "java.import.maven.enabled":false property, the Java language features are still alive and active in the project.
Even after a restart of VS Code, the Java language features are still alive and active.
Expected Result
Immediately after setting the "java.import.maven.enabled":false property, the Java language features for the project should stop working.
After a restart of VS Code, the Java language features for the project should not load.
Additional Informations
This issue was based on a conversation with @snjeza in the VS Code Java Extension gitter channel.
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
まず、Project2/.vscode/settings.json と java.import.maven.enabled 設定を使って、マルチルート ワークスペースの動作を再現します。既存の .project、.classpath、.settings ファイルが再起動後のインポートにどのような影響を与えるかを確認します。設定を無効にすると、これらのファイルを手動で削除しなくても無効化が反映されるか、必要なクリーンアップが明確に文書化されていれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- java, typescript, vscode
- 領域
- developer-experience, tooling
- issue の種類
- バグ
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 35/100