redhat-developer / redhat-developer/vscode-java

java.import.maven.enabled setting not honored

Abierto
#1,057 0 comentarios 3 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Maven
Lenguaje dominante
TypeScript
Estrellas
2.3k
Forks
546
Merge medio
20 h 1 min
PR fusionados (30 d)
11

Descripción

Currently, the "java.import.maven.enabled":false setting requires that the .project, .classpath files and the .settings directory be removed and the Java workspace cleaned before taking effect (see https://github.com/redhat-developer/vscode-java/issues/634#issuecomment-529466893). This is clunky and poorly-documented.

Ideally, setting the "java.import.maven.enabled":false should immediately take effect. Less ideally, there should be clear documentation around the use of this setting to instruct users to clear out the files and clean the workspace.

Truthfully, my use case is to disable the Java language features for one of the folders in my multi-root workspace. This is currently made possible by disabling the import, but one could imagine a world in which this is a different setting, which would take effect immediately.

Environment
  • Operating System: Windows 10 1809
  • JDK version: 1.8.0_221
  • Visual Studio Code version: 1.38.0
  • Java extension version: 0.48.0
Steps To Reproduce
  1. Open a fresh workspace in VS Code
  2. Open a folder containing a Java project - we'll call this Project1
    1. The Java extension will immediately import and start compiling the code
  3. Add another folder containing another Java project to the workspace - we'll call this Project2
    1. The Java extension will immediately import and start compiling the code
  4. Restart VS Code
    1. The Java extension will immediately start compiling the code for both projects
  5. Edit Project2's VS Code settings ([project2]/.vscode/settings.json) to contain the following:
    {
        "java.import.gradle.enabled":false,
        "java.import.maven.enabled":false
    }
    
  6. Restart VS Code
    1. The Java extensions will immediately start compiling the code for both projects
Current Result

Immediately after setting the "java.import.maven.enabled":false property, the Java language features are still alive and active in the project.
Even after a restart of VS Code, the Java language features are still alive and active.

Expected Result

Immediately after setting the "java.import.maven.enabled":false property, the Java language features for the project should stop working.
After a restart of VS Code, the Java language features for the project should not load.

Additional Informations

This issue was based on a conversation with @snjeza in the VS Code Java Extension gitter channel.

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Empiece reproduciendo el comportamiento del espacio de trabajo multi-root mediante Project2/.vscode/settings.json y la configuración java.import.maven.enabled. Compruebe cómo afectan los archivos .project, .classpath y .settings existentes a la importación después de reiniciar; se considera terminado cuando deshabilitar la configuración surte efecto sin tener que eliminar manualmente esos archivos, o cuando la limpieza necesaria está claramente documentada.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
java, typescript, vscode
Área
developer-experience, tooling
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.