redhat-developer / redhat-developer/vscode-java
java.import.maven.enabled setting not honored
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- TypeScript
- Sterne
- 2.3k
- Forks
- 546
- Ø Merge
- 20 Std. 1 Min.
- Gemergte PRs (30 T.)
- 11
Beschreibung
Currently, the "java.import.maven.enabled":false setting requires that the .project, .classpath files and the .settings directory be removed and the Java workspace cleaned before taking effect (see https://github.com/redhat-developer/vscode-java/issues/634#issuecomment-529466893). This is clunky and poorly-documented.
Ideally, setting the "java.import.maven.enabled":false should immediately take effect. Less ideally, there should be clear documentation around the use of this setting to instruct users to clear out the files and clean the workspace.
Truthfully, my use case is to disable the Java language features for one of the folders in my multi-root workspace. This is currently made possible by disabling the import, but one could imagine a world in which this is a different setting, which would take effect immediately.
Environment
- Operating System: Windows 10 1809
- JDK version: 1.8.0_221
- Visual Studio Code version: 1.38.0
- Java extension version: 0.48.0
Steps To Reproduce
- Open a fresh workspace in VS Code
- Open a folder containing a Java project - we'll call this Project1
- The Java extension will immediately import and start compiling the code
- Add another folder containing another Java project to the workspace - we'll call this Project2
- The Java extension will immediately import and start compiling the code
- Restart VS Code
- The Java extension will immediately start compiling the code for both projects
- Edit Project2's VS Code settings ([project2]/.vscode/settings.json) to contain the following:
{ "java.import.gradle.enabled":false, "java.import.maven.enabled":false } - Restart VS Code
- The Java extensions will immediately start compiling the code for both projects
Current Result
Immediately after setting the "java.import.maven.enabled":false property, the Java language features are still alive and active in the project.
Even after a restart of VS Code, the Java language features are still alive and active.
Expected Result
Immediately after setting the "java.import.maven.enabled":false property, the Java language features for the project should stop working.
After a restart of VS Code, the Java language features for the project should not load.
Additional Informations
This issue was based on a conversation with @snjeza in the VS Code Java Extension gitter channel.
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginnen Sie damit, das Verhalten des Multi-Root-Arbeitsbereichs mit Project2/.vscode/settings.json und der Einstellung java.import.maven.enabled zu reproduzieren. Prüfen Sie, wie sich die vorhandenen .project-, .classpath- und .settings-Dateien nach einem Neustart auf den Import auswirken; erledigt ist die Aufgabe, wenn das Deaktivieren der Einstellung wirksam wird, ohne diese Dateien manuell entfernen zu müssen, oder wenn die erforderliche Bereinigung klar dokumentiert ist.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- java, typescript, vscode
- Bereich
- developer-experience, tooling
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100