react / react/react-native

Animated.loop instances accumulate under the New Architecture on 0.77.3, degrading performance over a long-running session

オープン
#58,193 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

Needs: Author Feedback Needs: Repro
主要言語
C++
スター
127k
フォーク
25.3k
平均マージ
1日 23時間
マージ済み PR(30日)
4

説明

Description

On RN 0.77.3 with the New Architecture, looping animations appear not to be
released when their component unmounts, even though every call site stops the
loop in its cleanup. The number of live loops grows for the life of the
process, so each frame drives more of them and the app gets progressively
slower.

This is a long-running Android app that stays open for days without the process
restarting. A repeated user flow — mounting a screen, doing some work, then
returning to the previous screen — takes ~16s on a freshly started process and
~28s by the 40th repetition, measured with an automated UI soak. Only a process
restart clears it.

Evidence

Bisected to the 0.75.3 -> 0.77.3 upgrade. Building an older source tree
with only the RN upgrade applied — no other application changes — reproduces
it; the same tree on 0.75.3 is flat.

build run 1-10 run 31-40 slope
RN 0.75.3 18.0s 17.9s -0.005 s/iteration
RN 0.77.3 (only change) 20.8s 26.5s +0.280 s/iteration

CPU profiles (Hermes sampling profiler over the inspector, two equal 60s
windows, one early in the session and one after ~30 iterations):

[Host Function] startAnimatingNode     3.3% -> 14.6%
[Host Function] startOperationBatch    1.7% ->  7.6%
getSlope / getTForX / calcBezier       4.7% -> 19.9%
newtonRaphsonIterate                   1.1% ->  4.7%
__getNativeAnimationConfig             0.3% ->  1.3%

Roughly a 4x increase in absolute Animated work over equal windows. The hot
frames are the ones that run when an animation starts
(__getNativeAnimationConfig samples the easing curve into a lookup table at
start time), so animations are being started ever more often rather than
running longer.

Isolated to Animated.loop. Neutralising Animated.loop alone — leaving
every timing, spring and sequence untouched — removes the entire
regression:

build run 1-10 run 31-40 slope
unmodified 0.77.3 16.4s 26.1s +0.338 s/iteration
all animations disabled 18.0s 17.9s +0.003 s/iteration
only Animated.loop disabled 17.8s 18.0s ~0.000 s/iteration
What we ruled out by measurement
  • useNativeDriver — switching every call site to false changed nothing
    (+0.335 vs +0.338), so this is not the native animation module specifically.
  • Component/view retention — live Views and AppContexts (dumpsys meminfo)
    are flat across the run; threads and file descriptors fall slightly.
  • Leaked listeners, unbounded JS containers, navigation stacking (we use
    replace/popToTop), our list renderer, NativeWind's babel transform, and
    third-party SDK versions.
  • Hermes heap growth is real (40 -> 80 MB across 40 iterations) but is not
    the cause: it still doubles with loops disabled while timings stay flat.

Every loop on the affected path already calls .stop() in its effect cleanup.

Steps to reproduce

We do not yet have a minimal reproduction — the evidence above comes from a
large application. The pattern that triggers it here is a screen that mounts
several components each running an infinite Animated.loop, where that screen
is mounted and unmounted repeatedly, with the New Architecture enabled on
Android.

Happy to build a minimal repro if that would help; filing now in case the
profile signature is already recognisable to someone.

React Native Version

0.77.3

Affected Platforms

Runtime - Android

Areas

Fabric - The New Renderer

Environment
  • Android 7.1.2, armeabi-v7a, low-end ARM SoC (2 GB RAM)
  • Hermes enabled, New Architecture enabled
  • Release build (minified, --dev=false)

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

調査の方向性

Animated.loop のエントリポイントから開始し、Android で New Architecture を有効にした場合の React Native 0.75.3 と 0.77.3 の動作を比較します。複数の無限ループを使って画面のマウントとアンマウントを繰り返し再現し、その後、停止したループが蓄積しなくなっていることと、長時間の soak テストが安定していることを確認します。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
android, react-native
領域
mobile, performance
issue の種類
バグ
難易度
4/5
見積もり時間
3〜5日
活発さ
活発
明瞭さ
説明が足りない
初心者へのやさしさ
40/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。