react / react/react-native

Animated.loop instances accumulate under the New Architecture on 0.77.3, degrading performance over a long-running session

未关闭
#58,193 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

Needs: Author Feedback Needs: Repro
主要语言
C++
星标
127k
派生
25.3k
平均合并
1 天 23 小时
30 天内合并 PR
4

描述

Description

On RN 0.77.3 with the New Architecture, looping animations appear not to be
released when their component unmounts, even though every call site stops the
loop in its cleanup. The number of live loops grows for the life of the
process, so each frame drives more of them and the app gets progressively
slower.

This is a long-running Android app that stays open for days without the process
restarting. A repeated user flow — mounting a screen, doing some work, then
returning to the previous screen — takes ~16s on a freshly started process and
~28s by the 40th repetition, measured with an automated UI soak. Only a process
restart clears it.

Evidence

Bisected to the 0.75.3 -> 0.77.3 upgrade. Building an older source tree
with only the RN upgrade applied — no other application changes — reproduces
it; the same tree on 0.75.3 is flat.

build run 1-10 run 31-40 slope
RN 0.75.3 18.0s 17.9s -0.005 s/iteration
RN 0.77.3 (only change) 20.8s 26.5s +0.280 s/iteration

CPU profiles (Hermes sampling profiler over the inspector, two equal 60s
windows, one early in the session and one after ~30 iterations):

[Host Function] startAnimatingNode     3.3% -> 14.6%
[Host Function] startOperationBatch    1.7% ->  7.6%
getSlope / getTForX / calcBezier       4.7% -> 19.9%
newtonRaphsonIterate                   1.1% ->  4.7%
__getNativeAnimationConfig             0.3% ->  1.3%

Roughly a 4x increase in absolute Animated work over equal windows. The hot
frames are the ones that run when an animation starts
(__getNativeAnimationConfig samples the easing curve into a lookup table at
start time), so animations are being started ever more often rather than
running longer.

Isolated to Animated.loop. Neutralising Animated.loop alone — leaving
every timing, spring and sequence untouched — removes the entire
regression:

build run 1-10 run 31-40 slope
unmodified 0.77.3 16.4s 26.1s +0.338 s/iteration
all animations disabled 18.0s 17.9s +0.003 s/iteration
only Animated.loop disabled 17.8s 18.0s ~0.000 s/iteration
What we ruled out by measurement
  • useNativeDriver — switching every call site to false changed nothing
    (+0.335 vs +0.338), so this is not the native animation module specifically.
  • Component/view retention — live Views and AppContexts (dumpsys meminfo)
    are flat across the run; threads and file descriptors fall slightly.
  • Leaked listeners, unbounded JS containers, navigation stacking (we use
    replace/popToTop), our list renderer, NativeWind's babel transform, and
    third-party SDK versions.
  • Hermes heap growth is real (40 -> 80 MB across 40 iterations) but is not
    the cause: it still doubles with loops disabled while timings stay flat.

Every loop on the affected path already calls .stop() in its effect cleanup.

Steps to reproduce

We do not yet have a minimal reproduction — the evidence above comes from a
large application. The pattern that triggers it here is a screen that mounts
several components each running an infinite Animated.loop, where that screen
is mounted and unmounted repeatedly, with the New Architecture enabled on
Android.

Happy to build a minimal repro if that would help; filing now in case the
profile signature is already recognisable to someone.

React Native Version

0.77.3

Affected Platforms

Runtime - Android

Areas

Fabric - The New Renderer

Environment
  • Android 7.1.2, armeabi-v7a, low-end ARM SoC (2 GB RAM)
  • Hermes enabled, New Architecture enabled
  • Release build (minified, --dev=false)

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

从 Animated.loop 入口点开始,在 Android 上启用 New Architecture,比较 React Native 0.75.3 和 0.77.3 之间的行为差异。使用多个无限循环重现屏幕反复挂载和卸载的情况,然后验证已停止的循环不再累积,并确认长时间 soak 测试保持平稳。

由索引模型根据 Issue 内容生成。

评估

技术栈
android, react-native
领域
mobile, performance
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
活跃
描述清晰度
需要澄清
新手友好度
40/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。