react / react/react-native

Animated.loop instances accumulate under the New Architecture on 0.77.3, degrading performance over a long-running session

Abierto
#58,193 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Needs: Author Feedback Needs: Repro
Lenguaje dominante
C++
Estrellas
127k
Forks
25.3k
Merge medio
1 d 23 h
PR fusionados (30 d)
4

Descripción

Description

On RN 0.77.3 with the New Architecture, looping animations appear not to be
released when their component unmounts, even though every call site stops the
loop in its cleanup. The number of live loops grows for the life of the
process, so each frame drives more of them and the app gets progressively
slower.

This is a long-running Android app that stays open for days without the process
restarting. A repeated user flow — mounting a screen, doing some work, then
returning to the previous screen — takes ~16s on a freshly started process and
~28s by the 40th repetition, measured with an automated UI soak. Only a process
restart clears it.

Evidence

Bisected to the 0.75.3 -> 0.77.3 upgrade. Building an older source tree
with only the RN upgrade applied — no other application changes — reproduces
it; the same tree on 0.75.3 is flat.

build run 1-10 run 31-40 slope
RN 0.75.3 18.0s 17.9s -0.005 s/iteration
RN 0.77.3 (only change) 20.8s 26.5s +0.280 s/iteration

CPU profiles (Hermes sampling profiler over the inspector, two equal 60s
windows, one early in the session and one after ~30 iterations):

[Host Function] startAnimatingNode     3.3% -> 14.6%
[Host Function] startOperationBatch    1.7% ->  7.6%
getSlope / getTForX / calcBezier       4.7% -> 19.9%
newtonRaphsonIterate                   1.1% ->  4.7%
__getNativeAnimationConfig             0.3% ->  1.3%

Roughly a 4x increase in absolute Animated work over equal windows. The hot
frames are the ones that run when an animation starts
(__getNativeAnimationConfig samples the easing curve into a lookup table at
start time), so animations are being started ever more often rather than
running longer.

Isolated to Animated.loop. Neutralising Animated.loop alone — leaving
every timing, spring and sequence untouched — removes the entire
regression:

build run 1-10 run 31-40 slope
unmodified 0.77.3 16.4s 26.1s +0.338 s/iteration
all animations disabled 18.0s 17.9s +0.003 s/iteration
only Animated.loop disabled 17.8s 18.0s ~0.000 s/iteration
What we ruled out by measurement
  • useNativeDriver — switching every call site to false changed nothing
    (+0.335 vs +0.338), so this is not the native animation module specifically.
  • Component/view retention — live Views and AppContexts (dumpsys meminfo)
    are flat across the run; threads and file descriptors fall slightly.
  • Leaked listeners, unbounded JS containers, navigation stacking (we use
    replace/popToTop), our list renderer, NativeWind's babel transform, and
    third-party SDK versions.
  • Hermes heap growth is real (40 -> 80 MB across 40 iterations) but is not
    the cause: it still doubles with loops disabled while timings stay flat.

Every loop on the affected path already calls .stop() in its effect cleanup.

Steps to reproduce

We do not yet have a minimal reproduction — the evidence above comes from a
large application. The pattern that triggers it here is a screen that mounts
several components each running an infinite Animated.loop, where that screen
is mounted and unmounted repeatedly, with the New Architecture enabled on
Android.

Happy to build a minimal repro if that would help; filing now in case the
profile signature is already recognisable to someone.

React Native Version

0.77.3

Affected Platforms

Runtime - Android

Areas

Fabric - The New Renderer

Environment
  • Android 7.1.2, armeabi-v7a, low-end ARM SoC (2 GB RAM)
  • Hermes enabled, New Architecture enabled
  • Release build (minified, --dev=false)

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza en el punto de entrada Animated.loop y compara su comportamiento entre React Native 0.75.3 y 0.77.3 con New Architecture habilitada en Android. Reproduce el montaje y desmontaje repetidos de la pantalla con varios bucles infinitos y, después, verifica que los bucles detenidos ya no se acumulen y que la prueba de larga duración permanezca estable.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
android, react-native
Área
mobile, performance
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Activo
Claridad
Necesita aclaración
Aptitud para principiantes
40/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.