Different behaviour of 1.0.0 wheels from pypi
まだ誰も着手していません。
- 主要言語
- Python
- スター
- 20.6k
- フォーク
- 3.3k
- PR マージ指標
- PR 指標を取得中
説明
Hello,
I noticed that the manylinux_2_17_x86_64.manylinux2014_x86_64 and py3-none-any pypi wheels behave differently.
Bug Report
...but I don't know specifically what the issue is 😬
I wrote a mypy plugin. It used to work correctly with mypy 0.920-0.991. Then the tests started failing in CI when 1.0.0 was released. I've easily reproduced that locally. Wanted to get to the bottom of it, so downloaded mypy source, checked out v1.0.0, installed the local package and... the tests passed.
I've only later discovered that when I use the py3-none-any wheel from pypi it also works as expected.
The plugin hooks into get_type_analyze_hook, get_method_signature_hook and get_function_signature_hook modifying instances of a specific class (joining Protocols together). I understand this is no place to seek help in my project, but I believe the issue is with these particular distributions and not on my end, since everything works correctly when using the source or the generic wheel.
Locally I'm testing everything with python 3.10.9, but I've also confirmed this is the case with 3.11.1 and it failed with 3.7.15 in CI (Github Actions).
To Reproduce
I wish I could provide a simpler example, but I'm afraid I can't. I've tried narrowing the issue down, but couldn't do it with a compiled version of mypy and the source version works beautifully 😬 .
git clone https://github.com/klausweiss/typing-protocol-intersection.git --branch mypy-1.0.0
cd typing-protocol-intersection
python -m venv venv-manylinux
source venv-manylinux/bin/activate
pip download mypy==1.0.0 --platform=manylinux_2_17_x86_64 --only-binary=:all:
pip install *.whl
mypy --config-file tests/test-mypy.ini tests/testcases/in_generic_param_unhappy_path.py --no-incremental
Outcome is
tests/testcases/in_generic_param_unhappy_path.py:49:15: error: Argument 1 to "get_x_y_1" has incompatible type "ProtocolIntersection[HasX]"; expected "DesiredObject" [arg-type]
tests/testcases/in_generic_param_unhappy_path.py:49:15: note: "ProtocolIntersection" is missing following "DesiredObject" protocol member:
tests/testcases/in_generic_param_unhappy_path.py:49:15: note: y
Found 1 error in 1 file (checked 1 source file)
Expected Behavior
Outcome:
tests/testcases/in_generic_param_unhappy_path.py:49:15: error: Argument 1 to "get_x_y_1" has incompatible type "ProtocolIntersection[HasX]"; expected "DesiredObject" [arg-type]
tests/testcases/in_generic_param_unhappy_path.py:49:15: note: "ProtocolIntersection" is missing following "DesiredObject" protocol member:
tests/testcases/in_generic_param_unhappy_path.py:49:15: note: y
tests/testcases/in_generic_param_unhappy_path.py:50:15: error: Argument 1 to "get_x_y_2" has incompatible type "typing_protocol_intersection.types.ProtocolIntersection[HasX]"; expected "typing_protocol_intersection.types.ProtocolIntersection[HasY, HasX]" [arg-type]
tests/testcases/in_generic_param_unhappy_path.py:50:15: note: "ProtocolIntersection" is missing following "ProtocolIntersection" protocol member:
tests/testcases/in_generic_param_unhappy_path.py:50:15: note: y
Found 2 errors in 1 file (checked 1 source file)
You get the expected outcome when you follow the same steps as above, but downloading a py3-any-none wheel instead:
git clone https://github.com/klausweiss/typing-protocol-intersection.git --branch mypy-1.0.0
cd typing-protocol-intersection
python -m venv venv-manylinux
source venv-manylinux/bin/activate
pip download mypy==1.0.0 --platform=none --only-binary=:all:
pip install *.whl
mypy --config-file tests/test-mypy.ini tests/testcases/in_generic_param_unhappy_path.py --no-incremental
Again, that's also the behavior I observed when cloning the mypy repo, checking out v1.0.0, and installing from a local directory.
Actual Behavior
See the To Reproduce section.
Your Environment
- Mypy version used:
v1.0.0 - Mypy command-line flags:
--no-incremental --config-file tests/test-mypy.ini - Mypy configuration options from
mypy.ini(and other config files):- contents of
tests/test-mypy.ini:[mypy] plugins = ../typing_protocol_intersection/mypy_plugin.py check_untyped_defs = True disallow_any_generics = True disallow_any_unimported = True disallow_incomplete_defs = True disallow_subclassing_any = True disallow_untyped_calls = True disallow_untyped_decorators = True disallow_untyped_defs = True implicit_reexport = False no_implicit_optional = True show_column_numbers = True show_error_codes = True strict_equality = True strict_optional = True warn_no_return = True warn_redundant_casts = True warn_return_any = True warn_unused_configs = True
- contents of
- Python version used:
3.10.9but also with3.11.1and3.7.15, haven't checked any others - OS: Manjaro Linux 5.15.91, glibc version 2.36
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
リンクされている typing-protocol-intersection の再現手順と、その mypy-1.0.0 ブランチから始めます。manylinux および py3-none-any wheel 用に提供されている pip download コマンドと mypy コマンドを実行し、その結果をソースチェックアウトと比較します。ディストリビューション固有の挙動が説明され、報告された再現結果に予期しない差異がなくなれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- python
- 領域
- devtools
- issue の種類
- バグ
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 停滞
- 明瞭さ
- 説明が足りない
- 初心者へのやさしさ
- 35/100