python / python/mypy

Different behaviour of 1.0.0 wheels from pypi

未关闭
#14,653 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

bug
主要语言
Python
星标
20.6k
派生
3.3k
PR 合并指标
PR 指标待抓取

描述

Hello,

I noticed that the manylinux_2_17_x86_64.manylinux2014_x86_64 and py3-none-any pypi wheels behave differently.

Bug Report

...but I don't know specifically what the issue is 😬
I wrote a mypy plugin. It used to work correctly with mypy 0.920-0.991. Then the tests started failing in CI when 1.0.0 was released. I've easily reproduced that locally. Wanted to get to the bottom of it, so downloaded mypy source, checked out v1.0.0, installed the local package and... the tests passed.
I've only later discovered that when I use the py3-none-any wheel from pypi it also works as expected.

The plugin hooks into get_type_analyze_hook, get_method_signature_hook and get_function_signature_hook modifying instances of a specific class (joining Protocols together). I understand this is no place to seek help in my project, but I believe the issue is with these particular distributions and not on my end, since everything works correctly when using the source or the generic wheel.

Locally I'm testing everything with python 3.10.9, but I've also confirmed this is the case with 3.11.1 and it failed with 3.7.15 in CI (Github Actions).

To Reproduce

I wish I could provide a simpler example, but I'm afraid I can't. I've tried narrowing the issue down, but couldn't do it with a compiled version of mypy and the source version works beautifully 😬 .

git clone https://github.com/klausweiss/typing-protocol-intersection.git --branch mypy-1.0.0
cd typing-protocol-intersection
python -m venv venv-manylinux
source venv-manylinux/bin/activate
pip download mypy==1.0.0 --platform=manylinux_2_17_x86_64 --only-binary=:all: 
pip install *.whl
mypy --config-file tests/test-mypy.ini tests/testcases/in_generic_param_unhappy_path.py --no-incremental

Outcome is

tests/testcases/in_generic_param_unhappy_path.py:49:15: error: Argument 1 to "get_x_y_1" has incompatible type "ProtocolIntersection[HasX]"; expected "DesiredObject"  [arg-type]
tests/testcases/in_generic_param_unhappy_path.py:49:15: note: "ProtocolIntersection" is missing following "DesiredObject" protocol member:
tests/testcases/in_generic_param_unhappy_path.py:49:15: note:     y
Found 1 error in 1 file (checked 1 source file)

Expected Behavior

Outcome:

tests/testcases/in_generic_param_unhappy_path.py:49:15: error: Argument 1 to "get_x_y_1" has incompatible type "ProtocolIntersection[HasX]"; expected "DesiredObject"  [arg-type]
tests/testcases/in_generic_param_unhappy_path.py:49:15: note: "ProtocolIntersection" is missing following "DesiredObject" protocol member:
tests/testcases/in_generic_param_unhappy_path.py:49:15: note:     y
tests/testcases/in_generic_param_unhappy_path.py:50:15: error: Argument 1 to "get_x_y_2" has incompatible type "typing_protocol_intersection.types.ProtocolIntersection[HasX]"; expected "typing_protocol_intersection.types.ProtocolIntersection[HasY, HasX]"  [arg-type]
tests/testcases/in_generic_param_unhappy_path.py:50:15: note: "ProtocolIntersection" is missing following "ProtocolIntersection" protocol member:
tests/testcases/in_generic_param_unhappy_path.py:50:15: note:     y
Found 2 errors in 1 file (checked 1 source file)

You get the expected outcome when you follow the same steps as above, but downloading a py3-any-none wheel instead:

git clone https://github.com/klausweiss/typing-protocol-intersection.git --branch mypy-1.0.0
cd typing-protocol-intersection
python -m venv venv-manylinux
source venv-manylinux/bin/activate
pip download mypy==1.0.0 --platform=none --only-binary=:all: 
pip install *.whl
mypy --config-file tests/test-mypy.ini tests/testcases/in_generic_param_unhappy_path.py --no-incremental

Again, that's also the behavior I observed when cloning the mypy repo, checking out v1.0.0, and installing from a local directory.

Actual Behavior

See the To Reproduce section.

Your Environment

  • Mypy version used: v1.0.0
  • Mypy command-line flags: --no-incremental --config-file tests/test-mypy.ini
  • Mypy configuration options from mypy.ini (and other config files):
    • contents of tests/test-mypy.ini:
      [mypy]
      plugins = ../typing_protocol_intersection/mypy_plugin.py
      check_untyped_defs = True
      disallow_any_generics = True
      disallow_any_unimported = True
      disallow_incomplete_defs = True
      disallow_subclassing_any = True
      disallow_untyped_calls = True
      disallow_untyped_decorators = True
      disallow_untyped_defs = True
      implicit_reexport = False
      no_implicit_optional = True
      show_column_numbers = True
      show_error_codes = True
      strict_equality = True
      strict_optional = True
      warn_no_return = True
      warn_redundant_casts = True
      warn_return_any = True
      warn_unused_configs = True
      
  • Python version used: 3.10.9 but also with 3.11.1 and 3.7.15, haven't checked any others
  • OS: Manjaro Linux 5.15.91, glibc version 2.36

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

从链接的 typing-protocol-intersection 复现以及其 mypy-1.0.0 分支开始。运行为 manylinux 和 py3-none-any wheel 提供的 pip download 和 mypy 命令,然后将这些结果与源代码 checkout 进行比较。当 distribution 特定的行为得到解释,并且报告的复现不再出现意外差异时,即表示完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
devtools
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
需要澄清
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。