python / python/mypy

Different behaviour of 1.0.0 wheels from pypi

Offen
#14,653 3 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

bug
Vorherrschende Sprache
Python
Sterne
20.6k
Forks
3.3k
PR-Merge-Kennzahlen
PR-Kennzahlen ausstehend

Beschreibung

Hello,

I noticed that the manylinux_2_17_x86_64.manylinux2014_x86_64 and py3-none-any pypi wheels behave differently.

Bug Report

...but I don't know specifically what the issue is 😬
I wrote a mypy plugin. It used to work correctly with mypy 0.920-0.991. Then the tests started failing in CI when 1.0.0 was released. I've easily reproduced that locally. Wanted to get to the bottom of it, so downloaded mypy source, checked out v1.0.0, installed the local package and... the tests passed.
I've only later discovered that when I use the py3-none-any wheel from pypi it also works as expected.

The plugin hooks into get_type_analyze_hook, get_method_signature_hook and get_function_signature_hook modifying instances of a specific class (joining Protocols together). I understand this is no place to seek help in my project, but I believe the issue is with these particular distributions and not on my end, since everything works correctly when using the source or the generic wheel.

Locally I'm testing everything with python 3.10.9, but I've also confirmed this is the case with 3.11.1 and it failed with 3.7.15 in CI (Github Actions).

To Reproduce

I wish I could provide a simpler example, but I'm afraid I can't. I've tried narrowing the issue down, but couldn't do it with a compiled version of mypy and the source version works beautifully 😬 .

git clone https://github.com/klausweiss/typing-protocol-intersection.git --branch mypy-1.0.0
cd typing-protocol-intersection
python -m venv venv-manylinux
source venv-manylinux/bin/activate
pip download mypy==1.0.0 --platform=manylinux_2_17_x86_64 --only-binary=:all: 
pip install *.whl
mypy --config-file tests/test-mypy.ini tests/testcases/in_generic_param_unhappy_path.py --no-incremental

Outcome is

tests/testcases/in_generic_param_unhappy_path.py:49:15: error: Argument 1 to "get_x_y_1" has incompatible type "ProtocolIntersection[HasX]"; expected "DesiredObject"  [arg-type]
tests/testcases/in_generic_param_unhappy_path.py:49:15: note: "ProtocolIntersection" is missing following "DesiredObject" protocol member:
tests/testcases/in_generic_param_unhappy_path.py:49:15: note:     y
Found 1 error in 1 file (checked 1 source file)

Expected Behavior

Outcome:

tests/testcases/in_generic_param_unhappy_path.py:49:15: error: Argument 1 to "get_x_y_1" has incompatible type "ProtocolIntersection[HasX]"; expected "DesiredObject"  [arg-type]
tests/testcases/in_generic_param_unhappy_path.py:49:15: note: "ProtocolIntersection" is missing following "DesiredObject" protocol member:
tests/testcases/in_generic_param_unhappy_path.py:49:15: note:     y
tests/testcases/in_generic_param_unhappy_path.py:50:15: error: Argument 1 to "get_x_y_2" has incompatible type "typing_protocol_intersection.types.ProtocolIntersection[HasX]"; expected "typing_protocol_intersection.types.ProtocolIntersection[HasY, HasX]"  [arg-type]
tests/testcases/in_generic_param_unhappy_path.py:50:15: note: "ProtocolIntersection" is missing following "ProtocolIntersection" protocol member:
tests/testcases/in_generic_param_unhappy_path.py:50:15: note:     y
Found 2 errors in 1 file (checked 1 source file)

You get the expected outcome when you follow the same steps as above, but downloading a py3-any-none wheel instead:

git clone https://github.com/klausweiss/typing-protocol-intersection.git --branch mypy-1.0.0
cd typing-protocol-intersection
python -m venv venv-manylinux
source venv-manylinux/bin/activate
pip download mypy==1.0.0 --platform=none --only-binary=:all: 
pip install *.whl
mypy --config-file tests/test-mypy.ini tests/testcases/in_generic_param_unhappy_path.py --no-incremental

Again, that's also the behavior I observed when cloning the mypy repo, checking out v1.0.0, and installing from a local directory.

Actual Behavior

See the To Reproduce section.

Your Environment

  • Mypy version used: v1.0.0
  • Mypy command-line flags: --no-incremental --config-file tests/test-mypy.ini
  • Mypy configuration options from mypy.ini (and other config files):
    • contents of tests/test-mypy.ini:
      [mypy]
      plugins = ../typing_protocol_intersection/mypy_plugin.py
      check_untyped_defs = True
      disallow_any_generics = True
      disallow_any_unimported = True
      disallow_incomplete_defs = True
      disallow_subclassing_any = True
      disallow_untyped_calls = True
      disallow_untyped_decorators = True
      disallow_untyped_defs = True
      implicit_reexport = False
      no_implicit_optional = True
      show_column_numbers = True
      show_error_codes = True
      strict_equality = True
      strict_optional = True
      warn_no_return = True
      warn_redundant_casts = True
      warn_return_any = True
      warn_unused_configs = True
      
  • Python version used: 3.10.9 but also with 3.11.1 and 3.7.15, haven't checked any others
  • OS: Manjaro Linux 5.15.91, glibc version 2.36

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Beginne mit der verknüpften Reproduktion von typing-protocol-intersection und ihrem mypy-1.0.0-Branch. Führe die bereitgestellten pip download- und mypy-Befehle für die manylinux- und py3-none-any-Wheels aus und vergleiche diese Ergebnisse anschließend mit einem Source-Checkout. Als erledigt gilt die Aufgabe, wenn das distributionsspezifische Verhalten erklärt ist und sich die gemeldete Reproduktion nicht mehr unerwartet unterscheidet.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
python
Bereich
devtools
Issue-Typ
Bug
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Veraltet
Klarheit
Muss geklärt werden
Anfängerfreundlichkeit
35/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.