Confusing behavior of ssl.create_default_context()
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 77.2k
- 分支
- 36k
- PR 合併指標
- PR 指標待擷取
描述
https://github.com/python/cpython/blob/8563966be4f171ccf615105ef9d3a5aa65a1de68/Lib/ssl.py#L697-L703
Hello!
Got tripped up by this logic recently. It might merit clarification in the docs.
Here's what I read:
Security considerations
Best defaults
For client use, if you don’t have any special requirements for your security policy, it is highly recommended that you use the create_default_context() function to create your SSL context. It will load the system’s trusted CA certificates, enable certificate validation and hostname checking, and try to choose reasonably secure protocol and cipher settings.
Note that it suggests using create_default_context() without any arguments for client use. This is correct. It is also confusing, since the default value of purpose is Purpose.SERVER_AUTH. When I read on, this seems like the wrong option:
Changed in version 3.10: The context now uses PROTOCOL_TLS_CLIENT or PROTOCOL_TLS_SERVER protocol instead of generic PROTOCOL_TLS.
After reading this too quickly, I incorrectly assume:
- Whatever argument is passed to
create_default_context()used to not matter but does matter now. - Since I want to run
PROTOCOL_TLS_CLIENTwith client auth, I had better passPurpose.CLIENT_AUTH.
In fact, CLIENT_AUTH sets PROTOCOL_TLS_SERVER and SERVER_AUTH sets PROTOCOL_TLS_CLIENT. This leads to the confusing error
>>> ssl.create_default_context(ssl.Purpose.CLIENT_AUTH).wrap_bio(ssl.MemoryBIO(), ssl.MemoryBIO())
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File ".../python3.10/ssl.py", line 527, in wrap_bio
return self.sslobject_class._create(
File ".../python3.10/ssl.py", line 866, in _create
sslobj = context._wrap_bio(
ssl.SSLError: Cannot create a client socket with a PROTOCOL_TLS_SERVER context (_ssl.c:801)
Proposed resolution
I submit that it's fundamentally confusing to control protocol selection via an x509v3 extended key usage string. For instance, suppose that I anticipate two certificates with different purposes will be involved in my connection: a client certificate with CLIENT_AUTH and server certificate with SERVER_AUTH. How should I invoke ssl.create_default_context() if I am the client? If I am the server?
I submit that clearer arguments would be
- Will this context be used in a server? Default
server_side=False, in accordance with the current default value ofpurpose. - Will this context request and/or validate a certificate from the other party? Default
cert_reqs=CERT_REQUIRED, because skipping certificate validation generally defeats the purpose of TLS.
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
閱讀 create_default_context() 文件以及 Lib/ssl.py 中 697-703 行附近的相關邏輯,然後重現 issue 中所示的 Purpose.CLIENT_AUTH 和 Purpose.SERVER_AUTH 行為。釐清用戶端/伺服器 purpose 的對應關係,並說明憑證與通訊協定選擇之間的關係;如果 API 應該變更,則記錄已接受的替代方案。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python
- 領域
- security
- Issue 類型
- 文件
- 難度
- 5/5
- 預估耗時
- 一週以上
- 活躍度
- 停滯
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100