python-humanize / python-humanize/humanize

intword: values between 10^36 and a googol format as huge decillion counts, and rounding to the next unit does not carry

未关闭
#356 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

主要语言
Python
星标
756
派生
148
平均合并
6 天 1 小时
30 天内合并 PR
12

描述

What happened

intword handles values up to 1000 decillion (10^36) and exactly a googol
(10^100) well, but everything in between formats as an enormous decillion
count:

>>> import humanize
>>> humanize.intword(10**100)
'1.0 googol'
>>> humanize.intword(10**100 - 10**93)
'9999999000000000610151082626636586748864734715312950532670947852288.0 decillion'
>>> humanize.intword(10**50)
'100000000000000000.0 decillion'

A 67 digit unit count defeats the purpose of a human readable number, and
a value just below a googol that rounds up to it never carries to
"1.0 googol".

Verified on humanize 4.16.0 (published wheel) and on current main
(c3a124c), Python 3.11.

Why this looks like a bug rather than a choice

This is the same class of boundary behavior that #328 recently fixed for
metric() (carry to the next SI prefix when rounding reaches 1000). The
powers list jumps from decillion (10^33) to googol (10^100), and the
selection loop picks decillion for anything under a googol, no matter how
large the resulting count is. Values above the largest power already fall
back to str(value), which suggests the intended behavior for
"no reasonable unit" is the plain number, not a unit with a 67 digit
multiplier.

Expected

One of the following, whichever matches the project's intent:

  1. Values whose formatted count reaches 1000 of a unit with no adjacent
    next power fall back to str(value) (consistent with the existing
    above-maximum behavior), and values that round up to exactly the next
    power carry to it ("1.0 googol"), consistent with #328's carry rule.
  2. Or simply fall back to str(value) for the whole gap between 10^36
    and 10^100.

I am happy to open a PR with regression tests for the boundary cases once
maintainers confirm which behavior is intended.

How this was found

An automated review gate proposed edge case tests for the recent number.py
changes (the #328 carry fix among them) and executed them against the
code; the "carry just below the next unit" test failed with the output
above. The failing test and its observed output are reproducible by hand
as shown.

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

从报告中引用的 number.py 更改开始,并使用 Python 3.11 重现边界示例。向 maintainers 确认该缺口应回退到 str(value),还是在 googol 边界继续处理,然后为选定的行为添加回归测试。当接近 10^100 的值不再产生巨大的 decillion 计数,且舍入遵循商定的规则时,即视为完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
backend
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
冷清
描述清晰度
基本清楚
新手友好度
52/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。