python-humanize / python-humanize/humanize
intword: values between 10^36 and a googol format as huge decillion counts, and rounding to the next unit does not carry
Nessuno ha ancora preso questa issue.
- Lingua principale
- Python
- Stelle
- 756
- Fork
- 148
- Merge medio
- 6g 1h
- PR unite (30g)
- 12
Descrizione
What happened
intword handles values up to 1000 decillion (10^36) and exactly a googol
(10^100) well, but everything in between formats as an enormous decillion
count:
>>> import humanize
>>> humanize.intword(10**100)
'1.0 googol'
>>> humanize.intword(10**100 - 10**93)
'9999999000000000610151082626636586748864734715312950532670947852288.0 decillion'
>>> humanize.intword(10**50)
'100000000000000000.0 decillion'
A 67 digit unit count defeats the purpose of a human readable number, and
a value just below a googol that rounds up to it never carries to
"1.0 googol".
Verified on humanize 4.16.0 (published wheel) and on current main
(c3a124c), Python 3.11.
Why this looks like a bug rather than a choice
This is the same class of boundary behavior that #328 recently fixed for
metric() (carry to the next SI prefix when rounding reaches 1000). The
powers list jumps from decillion (10^33) to googol (10^100), and the
selection loop picks decillion for anything under a googol, no matter how
large the resulting count is. Values above the largest power already fall
back to str(value), which suggests the intended behavior for
"no reasonable unit" is the plain number, not a unit with a 67 digit
multiplier.
Expected
One of the following, whichever matches the project's intent:
- Values whose formatted count reaches 1000 of a unit with no adjacent
next power fall back tostr(value)(consistent with the existing
above-maximum behavior), and values that round up to exactly the next
power carry to it ("1.0 googol"), consistent with #328's carry rule. - Or simply fall back to
str(value)for the whole gap between 10^36
and 10^100.
I am happy to open a PR with regression tests for the boundary cases once
maintainers confirm which behavior is intended.
How this was found
An automated review gate proposed edge case tests for the recent number.py
changes (the #328 carry fix among them) and executed them against the
code; the "carry just below the next unit" test failed with the output
above. The failing test and its observed output are reproducible by hand
as shown.
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
Inizia con le modifiche a number.py indicate nel report e riproduci gli esempi ai limiti con Python 3.11. Conferma con i maintainer se il divario debba ricorrere a str(value) o proseguire al confine di googol, quindi aggiungi test di regressione per il comportamento selezionato. Il lavoro è completato quando i valori vicini a 10^100 non producono più quantità enormi di decilioni e l’arrotondamento segue la regola concordata.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- python
- Ambito
- backend
- Tipo di issue
- Bug
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Stato di attività
- Tranquilla
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 52/100