python-humanize / python-humanize/humanize

intword: values between 10^36 and a googol format as huge decillion counts, and rounding to the next unit does not carry

Abierto
#356 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Lenguaje dominante
Python
Estrellas
757
Forks
148
Merge medio
6 d 1 h
PR fusionados (30 d)
12

Descripción

What happened

intword handles values up to 1000 decillion (10^36) and exactly a googol
(10^100) well, but everything in between formats as an enormous decillion
count:

>>> import humanize
>>> humanize.intword(10**100)
'1.0 googol'
>>> humanize.intword(10**100 - 10**93)
'9999999000000000610151082626636586748864734715312950532670947852288.0 decillion'
>>> humanize.intword(10**50)
'100000000000000000.0 decillion'

A 67 digit unit count defeats the purpose of a human readable number, and
a value just below a googol that rounds up to it never carries to
"1.0 googol".

Verified on humanize 4.16.0 (published wheel) and on current main
(c3a124c), Python 3.11.

Why this looks like a bug rather than a choice

This is the same class of boundary behavior that #328 recently fixed for
metric() (carry to the next SI prefix when rounding reaches 1000). The
powers list jumps from decillion (10^33) to googol (10^100), and the
selection loop picks decillion for anything under a googol, no matter how
large the resulting count is. Values above the largest power already fall
back to str(value), which suggests the intended behavior for
"no reasonable unit" is the plain number, not a unit with a 67 digit
multiplier.

Expected

One of the following, whichever matches the project's intent:

  1. Values whose formatted count reaches 1000 of a unit with no adjacent
    next power fall back to str(value) (consistent with the existing
    above-maximum behavior), and values that round up to exactly the next
    power carry to it ("1.0 googol"), consistent with #328's carry rule.
  2. Or simply fall back to str(value) for the whole gap between 10^36
    and 10^100.

I am happy to open a PR with regression tests for the boundary cases once
maintainers confirm which behavior is intended.

How this was found

An automated review gate proposed edge case tests for the recent number.py
changes (the #328 carry fix among them) and executed them against the
code; the "carry just below the next unit" test failed with the output
above. The failing test and its observed output are reproducible by hand
as shown.

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza con los cambios de number.py mencionados en el informe y reproduce los ejemplos de los límites con Python 3.11. Confirma con los maintainers si el hueco debe recurrir a str(value) o continuar en el límite de googol, y después añade pruebas de regresión para el comportamiento seleccionado. Se considera terminado cuando los valores cercanos a 10^100 ya no producen cantidades enormes de decillones y el redondeo sigue la regla acordada.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
python
Área
backend
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Tranquilo
Claridad
Bastante claro
Aptitud para principiantes
52/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.