Dechunk incorrectly truncates string when it starts with a hex character
まだ誰も着手していません。
- 主要言語
- C
- スター
- 40.4k
- フォーク
- 8.2k
- 平均マージ
- 2日 13時間
- マージ済み PR(30日)
- 96
説明
Description
The dechunk filter removes the first line if it starts with a hex character. This is incorrect and used in attacks. I propose it just passes the data through literally if the first line does not contain a valid length.
The dechunk filter is meant to decode HTTP chunked transfer encoding. It is used in the fopen URL wrapper. If the response contains "Transfer-Encoding: Chunked", it is passed through the dechunk filter.
It reads a length prefix and then so many bytes, and it works correctly:
var_dump(file_get_contents(
"php://filter/dechunk/resource=data:text/plain,5\r\nhello\r\n"
));
// string(5) "hello"
If passed something that does not look chunked, it passes the data through literally:
var_dump(file_get_contents(
"php://filter/dechunk/resource=data:text/plain,mango"
));
// string(5) "mango"
This makes a bit of sense. It is clearly not chunked encoding, so it is probably not encoded, and this is the best it can do.
However, if the string starts with a character which is valid hex character (0-9, a-f, A-F), it removes the content:
var_dump(file_get_contents(
"php://filter/dechunk/resource=data:text/plain,apple"
));
// string(0) ""
This is a technical artifact of how the filter works. Besides that it is unexpected, it is also heavily misused in filter chain attacks. It creates an oracle that tells the attacker whether the string starts with a hex character.
I propose to change the filter so that it passes the data through literally if the first line is not a valid length.
var_dump(file_get_contents(
"php://filter/dechunk/resource=data:text/plain,apple"
));
// string(0) "apple"
This would make its behavior more consistent, and make it harder for attackers to abuse this function.
I think this will make filter chain attacks slightly harder, but not impossible.
This change it unlikely to break anyones program:
- dechunk is not documented;
- the happy flow of actually decoding chunked data keeps working the same;
- dechunk already returns the input unchanged for some inputs (not starting with hex characters).
Perhaps it should also raise a warning or notice when the encoding is incorrect, but that is not what this issue is about.
PHP Version
PHP 8.5.5 (cli) (built: Apr 7 2026 16:24:10) (NTS)
Copyright (c) The PHP Group
Built by Homebrew
Zend Engine v4.5.5, Copyright (c) Zend Technologies
with Zend OPcache v8.5.5, Copyright (c), by Zend Technologies
Operating System
No response
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
php://filter/dechunk エントリポイントを通じて例を再現し、次に dechunk フィルターの C 実装と既存のカバレッジを見つけてください。最初の行の無効な長さの処理を確認し、有効なチャンクのデコードを維持しながら、“apple” のような入力を変更せずに通過させます。示されたケースが期待される値を返せば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- c, php
- 領域
- backend, security
- issue の種類
- バグ
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 活発さ
- 静か
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 58/100