Dechunk incorrectly truncates string when it starts with a hex character
Personne n'a encore pris cette issue.
- Langage dominant
- C
- Étoiles
- 40.4k
- Forks
- 8.2k
- Merge moyen
- 2 j 13 h
- PR mergées (30 j)
- 96
Description
Description
The dechunk filter removes the first line if it starts with a hex character. This is incorrect and used in attacks. I propose it just passes the data through literally if the first line does not contain a valid length.
The dechunk filter is meant to decode HTTP chunked transfer encoding. It is used in the fopen URL wrapper. If the response contains "Transfer-Encoding: Chunked", it is passed through the dechunk filter.
It reads a length prefix and then so many bytes, and it works correctly:
var_dump(file_get_contents(
"php://filter/dechunk/resource=data:text/plain,5\r\nhello\r\n"
));
// string(5) "hello"
If passed something that does not look chunked, it passes the data through literally:
var_dump(file_get_contents(
"php://filter/dechunk/resource=data:text/plain,mango"
));
// string(5) "mango"
This makes a bit of sense. It is clearly not chunked encoding, so it is probably not encoded, and this is the best it can do.
However, if the string starts with a character which is valid hex character (0-9, a-f, A-F), it removes the content:
var_dump(file_get_contents(
"php://filter/dechunk/resource=data:text/plain,apple"
));
// string(0) ""
This is a technical artifact of how the filter works. Besides that it is unexpected, it is also heavily misused in filter chain attacks. It creates an oracle that tells the attacker whether the string starts with a hex character.
I propose to change the filter so that it passes the data through literally if the first line is not a valid length.
var_dump(file_get_contents(
"php://filter/dechunk/resource=data:text/plain,apple"
));
// string(0) "apple"
This would make its behavior more consistent, and make it harder for attackers to abuse this function.
I think this will make filter chain attacks slightly harder, but not impossible.
This change it unlikely to break anyones program:
- dechunk is not documented;
- the happy flow of actually decoding chunked data keeps working the same;
- dechunk already returns the input unchanged for some inputs (not starting with hex characters).
Perhaps it should also raise a warning or notice when the encoding is incorrect, but that is not what this issue is about.
PHP Version
PHP 8.5.5 (cli) (built: Apr 7 2026 16:24:10) (NTS)
Copyright (c) The PHP Group
Built by Homebrew
Zend Engine v4.5.5, Copyright (c) Zend Technologies
with Zend OPcache v8.5.5, Copyright (c), by Zend Technologies
Operating System
No response
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Reproduisez les exemples via le point d’entrée php://filter/dechunk, puis localisez l’implémentation en C du filtre dechunk et sa couverture existante. Vérifiez la gestion d’une longueur invalide sur la première ligne, tout en préservant le décodage valide des chunks et en laissant passer sans modification les entrées telles que « apple » ; le travail est terminé lorsque les cas démontrés renvoient les valeurs attendues.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- c, php
- Domaine
- backend, security
- Type d'issue
- Bug
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Activité
- Calme
- Clarté
- Plutôt claire
- Accessibilité débutants
- 58/100