php / php/php-src

Dechunk incorrectly truncates string when it starts with a hex character

Aperta
#21,983 10 commenti 1 reazione 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Extension: filter Feature Status: Requires RFC
Lingua principale
C
Stelle
40.4k
Fork
8.1k
Merge medio
2g 13h
PR unite (30g)
96

Descrizione

Description

The dechunk filter removes the first line if it starts with a hex character. This is incorrect and used in attacks. I propose it just passes the data through literally if the first line does not contain a valid length.

The dechunk filter is meant to decode HTTP chunked transfer encoding. It is used in the fopen URL wrapper. If the response contains "Transfer-Encoding: Chunked", it is passed through the dechunk filter.

It reads a length prefix and then so many bytes, and it works correctly:

var_dump(file_get_contents(
    "php://filter/dechunk/resource=data:text/plain,5\r\nhello\r\n"
));
// string(5) "hello"

If passed something that does not look chunked, it passes the data through literally:

var_dump(file_get_contents(
    "php://filter/dechunk/resource=data:text/plain,mango"
));
// string(5) "mango"

This makes a bit of sense. It is clearly not chunked encoding, so it is probably not encoded, and this is the best it can do.

However, if the string starts with a character which is valid hex character (0-9, a-f, A-F), it removes the content:

var_dump(file_get_contents(
    "php://filter/dechunk/resource=data:text/plain,apple"
));
// string(0) ""

This is a technical artifact of how the filter works. Besides that it is unexpected, it is also heavily misused in filter chain attacks. It creates an oracle that tells the attacker whether the string starts with a hex character.

I propose to change the filter so that it passes the data through literally if the first line is not a valid length.

var_dump(file_get_contents(
    "php://filter/dechunk/resource=data:text/plain,apple"
));
// string(0) "apple"

This would make its behavior more consistent, and make it harder for attackers to abuse this function.

I think this will make filter chain attacks slightly harder, but not impossible.

This change it unlikely to break anyones program:

  • dechunk is not documented;
  • the happy flow of actually decoding chunked data keeps working the same;
  • dechunk already returns the input unchanged for some inputs (not starting with hex characters).

Perhaps it should also raise a warning or notice when the encoding is incorrect, but that is not what this issue is about.

PHP Version
PHP 8.5.5 (cli) (built: Apr  7 2026 16:24:10) (NTS)
Copyright (c) The PHP Group
Built by Homebrew
Zend Engine v4.5.5, Copyright (c) Zend Technologies
    with Zend OPcache v8.5.5, Copyright (c), by Zend Technologies
Operating System

No response

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Riproduci gli esempi tramite l’entry point php://filter/dechunk, quindi individua l’implementazione in C del filtro dechunk e la relativa copertura esistente. Verifica la gestione di una lunghezza non valida nella prima riga, preservando la decodifica valida dei chunk e lasciando passare senza modifiche input come “apple”; il lavoro è completato quando i casi dimostrati restituiscono i valori attesi.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
c, php
Ambito
backend, security
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
58/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.