open-feature / open-feature/python-sdk-contrib
Restore the .gitmodules branch pins so Renovate tracks flagd submodule versions again
まだ誰も着手していません。
- 主要言語
- Python
- スター
- 27
- フォーク
- 33
- 平均マージ
- 5時間 7分
- マージ済み PR(30日)
- 9
説明
The branch pin on providers/openfeature-provider-flagd/openfeature/test-harness has been removed from .gitmodules twice: first in open-feature/python-sdk-contrib#347 (at v2.11.1), restored in open-feature/python-sdk-contrib#377, then removed again 8 days later in open-feature/python-sdk-contrib#386 (at v3.5.0). It reads as harmless — the exact SHA is still pinned — but it is the line Renovate uses to track testbed versions, and testbed updates here have been dead ever since.
The submodule sits at 7575a1d (v3.8.0) while the testbed has released v3.10.1. Exactly one manual bump has landed since, and a digest update is parked unactioned on the dependency dashboard in open-feature/python-sdk-contrib#126.
The PR restores the pin at v3.8.0, the tag it points at today.
open-feature/python-sdk-contrib#347 also dropped branch = protobuf-v0.6.1 from the schemas submodule, never restored. Across all four affected repos this is the only non-testbed submodule that lost a pin while still in use, so the PR covers it too.
That one needs a decision rather than a revert: schemas has since moved to 1daf5ff, tagged json/json-schema-v0.2.15 — a different tag series from the protobuf-* one it used to track. The PR pins it to the series it is actually on; flag it if tracking protobuf-* was deliberate.
Why this matters
Renovate's git-submodules manager reads branch from .gitmodules as the dependency's current version. With the pin present it resolves against the testbed's release tags and opens an ordinary version bump, rewriting the pin itself:
- branch = v2.10.1
+ branch = v2.10.2
Without it there is no version to compare against, so Renovate falls back to chasing the tip of the testbed default branch — a digest update. Those don't match the community-tooling preset's matchSourceUrls auto-create exemption, so they get parked behind a dashboard checkbox instead of becoming PRs. Net effect: no automated testbed updates in this repo since the removal.
The fix
The attached PR restores branch = <tag> on the testbed submodule, set to the tag it currently points at. That is the whole fix — no Renovate config change is needed, because the preset's existing exemption starts matching again as soon as the dependency resolves to a version.
Parent: open-feature/flagd-testbed#398
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
.gitmodules 内の影響を受けるサブモジュールエントリ、特に providers/openfeature-provider-flagd/openfeature/test-harness と schemas をまず確認し、それらの現在のコミットを指定されたタグと比較します。testbed ブランチのピンを v3.8.0 に復元し、適切な schemas のタグ系列を選択し、protobuf-v0.6.1 の選択を確認するかレビュー対象としてフラグ付けできれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- git
- 領域
- tooling
- issue の種類
- バグ
- 難易度
- 2/5
- 見積もり時間
- 1〜3時間
- 活発さ
- 活発
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 76/100