open-feature / open-feature/python-sdk-contrib

Restore the .gitmodules branch pins so Renovate tracks flagd submodule versions again

Aperta Adatta ai principianti
#421 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Lingua principale
Python
Stelle
27
Fork
33
Merge medio
5h 7m
PR unite (30g)
9

Descrizione

The branch pin on providers/openfeature-provider-flagd/openfeature/test-harness has been removed from .gitmodules twice: first in open-feature/python-sdk-contrib#347 (at v2.11.1), restored in open-feature/python-sdk-contrib#377, then removed again 8 days later in open-feature/python-sdk-contrib#386 (at v3.5.0). It reads as harmless — the exact SHA is still pinned — but it is the line Renovate uses to track testbed versions, and testbed updates here have been dead ever since.

The submodule sits at 7575a1d (v3.8.0) while the testbed has released v3.10.1. Exactly one manual bump has landed since, and a digest update is parked unactioned on the dependency dashboard in open-feature/python-sdk-contrib#126.

The PR restores the pin at v3.8.0, the tag it points at today.

open-feature/python-sdk-contrib#347 also dropped branch = protobuf-v0.6.1 from the schemas submodule, never restored. Across all four affected repos this is the only non-testbed submodule that lost a pin while still in use, so the PR covers it too.

That one needs a decision rather than a revert: schemas has since moved to 1daf5ff, tagged json/json-schema-v0.2.15 — a different tag series from the protobuf-* one it used to track. The PR pins it to the series it is actually on; flag it if tracking protobuf-* was deliberate.

Why this matters

Renovate's git-submodules manager reads branch from .gitmodules as the dependency's current version. With the pin present it resolves against the testbed's release tags and opens an ordinary version bump, rewriting the pin itself:

-	branch = v2.10.1
+	branch = v2.10.2

Without it there is no version to compare against, so Renovate falls back to chasing the tip of the testbed default branch — a digest update. Those don't match the community-tooling preset's matchSourceUrls auto-create exemption, so they get parked behind a dashboard checkbox instead of becoming PRs. Net effect: no automated testbed updates in this repo since the removal.

The fix

The attached PR restores branch = <tag> on the testbed submodule, set to the tag it currently points at. That is the whole fix — no Renovate config change is needed, because the preset's existing exemption starts matching again as soon as the dependency resolves to a version.

Parent: open-feature/flagd-testbed#398

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia ispezionando le voci dei sottomoduli interessati in .gitmodules, in particolare providers/openfeature-provider-flagd/openfeature/test-harness e schemas, e confronta i loro commit attuali con i tag indicati. Il lavoro è completato quando il pin del branch testbed viene ripristinato a v3.8.0 e viene selezionata la serie di tag appropriata di schemas, con la scelta di protobuf-v0.6.1 confermata o segnalata per la revisione.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
git
Ambito
tooling
Tipo di issue
Bug
Difficoltà
2/5
Tempo stimato
1-3 ore
Stato di attività
Attiva
Chiarezza
Abbastanza chiara
Idoneità per principianti
76/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.