open-feature / open-feature/python-sdk-contrib
Restore the .gitmodules branch pins so Renovate tracks flagd submodule versions again
还没有人认领这个 Issue。
- 主要语言
- Python
- 星标
- 27
- 派生
- 33
- 平均合并
- 5 小时 7 分钟
- 30 天内合并 PR
- 9
描述
The branch pin on providers/openfeature-provider-flagd/openfeature/test-harness has been removed from .gitmodules twice: first in open-feature/python-sdk-contrib#347 (at v2.11.1), restored in open-feature/python-sdk-contrib#377, then removed again 8 days later in open-feature/python-sdk-contrib#386 (at v3.5.0). It reads as harmless — the exact SHA is still pinned — but it is the line Renovate uses to track testbed versions, and testbed updates here have been dead ever since.
The submodule sits at 7575a1d (v3.8.0) while the testbed has released v3.10.1. Exactly one manual bump has landed since, and a digest update is parked unactioned on the dependency dashboard in open-feature/python-sdk-contrib#126.
The PR restores the pin at v3.8.0, the tag it points at today.
open-feature/python-sdk-contrib#347 also dropped branch = protobuf-v0.6.1 from the schemas submodule, never restored. Across all four affected repos this is the only non-testbed submodule that lost a pin while still in use, so the PR covers it too.
That one needs a decision rather than a revert: schemas has since moved to 1daf5ff, tagged json/json-schema-v0.2.15 — a different tag series from the protobuf-* one it used to track. The PR pins it to the series it is actually on; flag it if tracking protobuf-* was deliberate.
Why this matters
Renovate's git-submodules manager reads branch from .gitmodules as the dependency's current version. With the pin present it resolves against the testbed's release tags and opens an ordinary version bump, rewriting the pin itself:
- branch = v2.10.1
+ branch = v2.10.2
Without it there is no version to compare against, so Renovate falls back to chasing the tip of the testbed default branch — a digest update. Those don't match the community-tooling preset's matchSourceUrls auto-create exemption, so they get parked behind a dashboard checkbox instead of becoming PRs. Net effect: no automated testbed updates in this repo since the removal.
The fix
The attached PR restores branch = <tag> on the testbed submodule, set to the tag it currently points at. That is the whole fix — no Renovate config change is needed, because the preset's existing exemption starts matching again as soon as the dependency resolves to a version.
Parent: open-feature/flagd-testbed#398
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
首先检查 .gitmodules 中受影响的子模块条目,尤其是 providers/openfeature-provider-flagd/openfeature/test-harness 和 schemas,并将它们当前的提交与所述标签进行比较。完成的标准是将 testbed 分支的固定版本恢复为 v3.8.0,并选择适当的 schemas 标签系列,同时确认 protobuf-v0.6.1 这一选择,或将其标记为需要审查。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- git
- 领域
- tooling
- Issue 类型
- 缺陷
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 活跃度
- 活跃
- 描述清晰度
- 基本清楚
- 新手友好度
- 76/100