nodejs / nodejs/node

Windows: fs calls abort the process on a path containing U+10FFFF (libuv assert, fixed in libuv 1.52.0 but not in v22/v25)

オープン
#65,060 コメント 2 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

主要言語
JavaScript
スター
122k
フォーク
37.3k
平均マージ
4日 2時間
マージ済み PR(30日)
283

説明

Version

v22.15.0 (also affects v22.23.2, v25.9.0, v20.x by bundled-libuv version)

Platform

Microsoft Windows NT 10.0.26200.0 x64

Subsystem

fs

What steps will reproduce the bug?
require('fs').existsSync(String.fromCodePoint(0x10FFFF))

Output:

Assertion failed: code_point < 0x10FFFF, file c:\ws\deps\uv\src\idna.c, line 397

Exit code 127. The process is aborted, not an exception.

statSync and readFileSync behave identically. It is not catchable:

try { require('fs').statSync(String.fromCodePoint(0x10FFFF)); }
catch (e) { console.log('caught:', e.code); }
console.log('reached end');   // never printed

Control — the neighbouring code point is handled correctly:

require('fs').existsSync(String.fromCodePoint(0x10FFFE))   // returns false

U+10FFFD is likewise fine. Only U+10FFFF, the maximum legal Unicode scalar value, aborts.

How often does it reproduce? Is there a required condition?

Every time, on Windows. The path need not exist — the abort happens during the UTF-8 → UTF-16 path conversion, before any filesystem access.

What is the expected behavior? Why is that the expected behavior?

ENOENT (or any throw), as with every other non-existent path. U+10FFFF is a valid Unicode scalar value and a legal character in a JS string, so it can arrive from any untrusted input that is used as a path.

The important part is not that it fails, but that it fails un-catchably. A library cannot defend itself with try/catch, so any code that stats or reads a caller-supplied path can have its process killed. That is a denial-of-service vector for anything that takes a path from user input, a config file, or a network request.

What do you see instead?

The process aborts with the libuv assertion above.

Additional information

This is already fixed in libuv, but the fix has not reached all Node release lines.

libuv commit 73bfbb9"idna: fix assert in wtf8_to_utf16 conversion" (libuv#5021, 2026-02-04) — corrects an off-by-one in uv_wtf8_to_utf16:

      if (code_point > 0xFFFF) {
-       assert(code_point < 0x10FFFF);
+       assert(code_point <= 0x10FFFF);

It also adds a regression test for exactly this input ("\xF4\x8F\xBF\xBF").

That fix first shipped in libuv v1.52.0 (2026-02-11). Bundled libuv by Node release line:

line latest bundled libuv affected
v26 26.7.0 1.52.1 no
v25 25.9.0 1.51.0 yes
v24 24.19.0 1.52.1 no
v22 (LTS) 22.23.2 1.51.0 yes
v20 20.20.2 1.46.0 yes

So current v22 LTS is still affected, which is the reason for this report — v24 and v26 already carry the fix.

Reproduced directly on v22.15.0 (libuv 1.49.2). v22.23.2, v25.9.0 and v20.x are identified as affected from the bundled libuv version and the commit's release tag rather than executed on each line.

Would a libuv update (or a backport of this one-line change) to the v22 line be in scope? Happy to open the PR if that is the preferred route.

Found when a property-based test in a downstream project generated arbitrary strings and killed the test worker with no assertion output, roughly one run in five.

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

調査の方向性

まず String.fromCodePoint(0x10FFFF) を使って Windows の fs の再現手順を実行し、次に deps/uv/src/idna.c と、libuv のコミット 73bfbb9 で追加されたリグレッションテストを調べます。v22 にバンドルされた libuv の更新またはバックポートの経路を確認し、同じ呼び出しが abort せず、代わりに通常のファイルシステムエラーの挙動を返すことを検証します。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
javascript, node.js
領域
backend, operating-systems
issue の種類
バグ
難易度
3/5
見積もり時間
1〜2日
活発さ
静か
明瞭さ
おおむね明確
初心者へのやさしさ
58/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。