nodejs / nodejs/node

Windows: fs calls abort the process on a path containing U+10FFFF (libuv assert, fixed in libuv 1.52.0 but not in v22/v25)

未关闭
#65,060 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

主要语言
JavaScript
星标
122k
派生
37.4k
平均合并
4 天 3 小时
30 天内合并 PR
272

描述

Version

v22.15.0 (also affects v22.23.2, v25.9.0, v20.x by bundled-libuv version)

Platform

Microsoft Windows NT 10.0.26200.0 x64

Subsystem

fs

What steps will reproduce the bug?
require('fs').existsSync(String.fromCodePoint(0x10FFFF))

Output:

Assertion failed: code_point < 0x10FFFF, file c:\ws\deps\uv\src\idna.c, line 397

Exit code 127. The process is aborted, not an exception.

statSync and readFileSync behave identically. It is not catchable:

try { require('fs').statSync(String.fromCodePoint(0x10FFFF)); }
catch (e) { console.log('caught:', e.code); }
console.log('reached end');   // never printed

Control — the neighbouring code point is handled correctly:

require('fs').existsSync(String.fromCodePoint(0x10FFFE))   // returns false

U+10FFFD is likewise fine. Only U+10FFFF, the maximum legal Unicode scalar value, aborts.

How often does it reproduce? Is there a required condition?

Every time, on Windows. The path need not exist — the abort happens during the UTF-8 → UTF-16 path conversion, before any filesystem access.

What is the expected behavior? Why is that the expected behavior?

ENOENT (or any throw), as with every other non-existent path. U+10FFFF is a valid Unicode scalar value and a legal character in a JS string, so it can arrive from any untrusted input that is used as a path.

The important part is not that it fails, but that it fails un-catchably. A library cannot defend itself with try/catch, so any code that stats or reads a caller-supplied path can have its process killed. That is a denial-of-service vector for anything that takes a path from user input, a config file, or a network request.

What do you see instead?

The process aborts with the libuv assertion above.

Additional information

This is already fixed in libuv, but the fix has not reached all Node release lines.

libuv commit 73bfbb9"idna: fix assert in wtf8_to_utf16 conversion" (libuv#5021, 2026-02-04) — corrects an off-by-one in uv_wtf8_to_utf16:

      if (code_point > 0xFFFF) {
-       assert(code_point < 0x10FFFF);
+       assert(code_point <= 0x10FFFF);

It also adds a regression test for exactly this input ("\xF4\x8F\xBF\xBF").

That fix first shipped in libuv v1.52.0 (2026-02-11). Bundled libuv by Node release line:

line latest bundled libuv affected
v26 26.7.0 1.52.1 no
v25 25.9.0 1.51.0 yes
v24 24.19.0 1.52.1 no
v22 (LTS) 22.23.2 1.51.0 yes
v20 20.20.2 1.46.0 yes

So current v22 LTS is still affected, which is the reason for this report — v24 and v26 already carry the fix.

Reproduced directly on v22.15.0 (libuv 1.49.2). v22.23.2, v25.9.0 and v20.x are identified as affected from the bundled libuv version and the commit's release tag rather than executed on each line.

Would a libuv update (or a backport of this one-line change) to the v22 line be in scope? Happy to open the PR if that is the preferred route.

Found when a property-based test in a downstream project generated arbitrary strings and killed the test worker with no assertion output, roughly one run in five.

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

先使用 String.fromCodePoint(0x10FFFF) 运行 Windows fs 复现,然后检查 deps/uv/src/idna.c 以及 libuv 提交 73bfbb9 添加的回归测试。检查 v22 中捆绑的 libuv 更新或 backport 路径,并验证相同的调用不再中止,而是返回正常的文件系统错误行为。

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript, node.js
领域
backend, operating-systems
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
冷清
描述清晰度
基本清楚
新手友好度
58/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。