nodejs / nodejs/node

Windows: fs calls abort the process on a path containing U+10FFFF (libuv assert, fixed in libuv 1.52.0 but not in v22/v25)

Ouverte
#65,060 2 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Langage dominant
JavaScript
Étoiles
122k
Forks
37.3k
Merge moyen
4 j 2 h
PR mergées (30 j)
283

Description

Version

v22.15.0 (also affects v22.23.2, v25.9.0, v20.x by bundled-libuv version)

Platform

Microsoft Windows NT 10.0.26200.0 x64

Subsystem

fs

What steps will reproduce the bug?
require('fs').existsSync(String.fromCodePoint(0x10FFFF))

Output:

Assertion failed: code_point < 0x10FFFF, file c:\ws\deps\uv\src\idna.c, line 397

Exit code 127. The process is aborted, not an exception.

statSync and readFileSync behave identically. It is not catchable:

try { require('fs').statSync(String.fromCodePoint(0x10FFFF)); }
catch (e) { console.log('caught:', e.code); }
console.log('reached end');   // never printed

Control — the neighbouring code point is handled correctly:

require('fs').existsSync(String.fromCodePoint(0x10FFFE))   // returns false

U+10FFFD is likewise fine. Only U+10FFFF, the maximum legal Unicode scalar value, aborts.

How often does it reproduce? Is there a required condition?

Every time, on Windows. The path need not exist — the abort happens during the UTF-8 → UTF-16 path conversion, before any filesystem access.

What is the expected behavior? Why is that the expected behavior?

ENOENT (or any throw), as with every other non-existent path. U+10FFFF is a valid Unicode scalar value and a legal character in a JS string, so it can arrive from any untrusted input that is used as a path.

The important part is not that it fails, but that it fails un-catchably. A library cannot defend itself with try/catch, so any code that stats or reads a caller-supplied path can have its process killed. That is a denial-of-service vector for anything that takes a path from user input, a config file, or a network request.

What do you see instead?

The process aborts with the libuv assertion above.

Additional information

This is already fixed in libuv, but the fix has not reached all Node release lines.

libuv commit 73bfbb9"idna: fix assert in wtf8_to_utf16 conversion" (libuv#5021, 2026-02-04) — corrects an off-by-one in uv_wtf8_to_utf16:

      if (code_point > 0xFFFF) {
-       assert(code_point < 0x10FFFF);
+       assert(code_point <= 0x10FFFF);

It also adds a regression test for exactly this input ("\xF4\x8F\xBF\xBF").

That fix first shipped in libuv v1.52.0 (2026-02-11). Bundled libuv by Node release line:

line latest bundled libuv affected
v26 26.7.0 1.52.1 no
v25 25.9.0 1.51.0 yes
v24 24.19.0 1.52.1 no
v22 (LTS) 22.23.2 1.51.0 yes
v20 20.20.2 1.46.0 yes

So current v22 LTS is still affected, which is the reason for this report — v24 and v26 already carry the fix.

Reproduced directly on v22.15.0 (libuv 1.49.2). v22.23.2, v25.9.0 and v20.x are identified as affected from the bundled libuv version and the commit's release tag rather than executed on each line.

Would a libuv update (or a backport of this one-line change) to the v22 line be in scope? Happy to open the PR if that is the preferred route.

Found when a property-based test in a downstream project generated arbitrary strings and killed the test worker with no assertion output, roughly one run in five.

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Piste de recherche

Commencez par exécuter la reproduction fs sous Windows avec String.fromCodePoint(0x10FFFF), puis inspectez deps/uv/src/idna.c et le test de régression ajouté par le commit libuv 73bfbb9. Vérifiez la mise à jour de libuv intégrée à v22 ou la voie de backport, et confirmez que le même appel n’abandonne plus le processus et renvoie à la place le comportement normal d’erreur du système de fichiers.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
javascript, node.js
Domaine
backend, operating-systems
Type d'issue
Bug
Difficulté
3/5
Temps estimé
1-2 jours
Activité
Calme
Clarté
Plutôt claire
Accessibilité débutants
58/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.