microsoft / microsoft/TypeScript
Array with option allof in definition to tell TS that all options must be implemented from that array
まだ誰も着手していません。
- 主要言語
- Go
- スター
- 111k
- フォーク
- 14.4k
- 平均マージ
- 1日 19時間
- マージ済み PR(30日)
- 117
説明
🔍 Search Terms
Typescript Define Array type with variations
typescript array mandatory
typescript array with predefined options
✅ Viability Checklist
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
⭐ Suggestion
Typescript should be extended by a list of available options which a type must implement mandatory
type LanguageLocale = "en-gb" | "de" | "fr" | "nl-nl" | "nb-NO"
[
{ id: 'en-gb', name: 'EN' },
{ id: 'de', name: 'DE' },
{ id: 'fr', name: 'FR' },
{ id: 'nl-nl', name: 'NL' },
] satisfies {id: allof LanguageLocale, name: string}[]
here in my suggestion the keyword allof would describe that this array need to implement all options of LanguageLocale.
allof should be only usable together with [] or in case definition is split it should be ignored (e.g. LanguageEntry is used directly somewhere)
type LanguageLocale = "en-gb" | "de" | "fr" | "nl-nl" | "nb-NO"
type LanguageEntry = {id: allO fLanaugeLocale, name: string}
type LanguageEntries = LanguageEntry[]
It should work as well for type Array<T>
📃 Motivating Example
The motivation is to find places in the code where options are missed but mandatory
Imaging a Language Picker and you added a new language.
In the code the following was present.
It have had following data:
type LanguageLocale = "en-gb" | "de" | "fr" | "nl-nl"
[
{ id: 'en-gb', name: 'EN' },
{ id: 'de', name: 'DE' },
{ id: 'fr', name: 'FR' },
{ id: 'nl-nl', name: 'NL' },
] satisfies {id: LanguageLocale, name: string}[]
so after adding "nb-NO"
type LanguageLocale = "en-gb" | "de" | "fr" | "nl-nl"|"nb-NO"
[
{ id: 'en-gb', name: 'EN' },
{ id: 'de', name: 'DE' },
{ id: 'fr', name: 'FR' },
{ id: 'nl-nl', name: 'NL' },
] satisfies {id: LanguageLocale, name: string}[]
type is still valid and for now there is now simple solution to make nb-NO mandatory to implement
💻 Use Cases
It would it make easy to turn runtime errors ins transpile time errors by TS since this could be found before commiting.
There is a workaround but you need to repeat yourfself and have mulitple definitions. So in the end it's just moving the error away from the place in code to the type definition
type LanguageLocale = "en-gb" | "de" | "fr" | "nl-nl" | "nb-NO";
interface LanguageOption {
id: LanguageLocale;
name: string;
}
const allLanguageLocales: { [K in LanguageLocale]: null } = {
"en-gb": null,
"de": null,
"fr": null,
"nl-nl": null,
"nb-NO": null,
};
type CheckLanguages<T extends LanguageOption[]> = T extends (LanguageOption & { id: keyof typeof allLanguageLocales })[] ? T : never;
const languages = [
{ id: 'en-gb', name: i18n('EN') },
{ id: 'de', name: i18n('DE') },
{ id: 'fr', name: i18n('FR') },
{ id: 'nl-nl', name: i18n('NL') },
// { id: 'nb-NO', name: i18n('NO') }, // Uncomment this line to fix the error
] as const;
type CheckedLanguages = CheckLanguages<typeof languages>;
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
この issue では、ソースファイル、テスト、エントリポイントが指定されていません。まず提案された例と既存の workaround から始め、生成される JavaScript を変更せずに、Array を含む配列内で union のすべてのメンバーを型システムによって強制する方法を検討してください。両方の配列形式について提案が仕様化され、カバーされていれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- typescript
- 領域
- compilers
- issue の種類
- 機能追加
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 25/100