microsoft / microsoft/TypeScript
Array with option allof in definition to tell TS that all options must be implemented from that array
Nessuno ha ancora preso questa issue.
- Lingua principale
- Go
- Stelle
- 111k
- Fork
- 14.3k
- Merge medio
- 1g 19h
- PR unite (30g)
- 117
Descrizione
🔍 Search Terms
Typescript Define Array type with variations
typescript array mandatory
typescript array with predefined options
✅ Viability Checklist
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
⭐ Suggestion
Typescript should be extended by a list of available options which a type must implement mandatory
type LanguageLocale = "en-gb" | "de" | "fr" | "nl-nl" | "nb-NO"
[
{ id: 'en-gb', name: 'EN' },
{ id: 'de', name: 'DE' },
{ id: 'fr', name: 'FR' },
{ id: 'nl-nl', name: 'NL' },
] satisfies {id: allof LanguageLocale, name: string}[]
here in my suggestion the keyword allof would describe that this array need to implement all options of LanguageLocale.
allof should be only usable together with [] or in case definition is split it should be ignored (e.g. LanguageEntry is used directly somewhere)
type LanguageLocale = "en-gb" | "de" | "fr" | "nl-nl" | "nb-NO"
type LanguageEntry = {id: allO fLanaugeLocale, name: string}
type LanguageEntries = LanguageEntry[]
It should work as well for type Array<T>
📃 Motivating Example
The motivation is to find places in the code where options are missed but mandatory
Imaging a Language Picker and you added a new language.
In the code the following was present.
It have had following data:
type LanguageLocale = "en-gb" | "de" | "fr" | "nl-nl"
[
{ id: 'en-gb', name: 'EN' },
{ id: 'de', name: 'DE' },
{ id: 'fr', name: 'FR' },
{ id: 'nl-nl', name: 'NL' },
] satisfies {id: LanguageLocale, name: string}[]
so after adding "nb-NO"
type LanguageLocale = "en-gb" | "de" | "fr" | "nl-nl"|"nb-NO"
[
{ id: 'en-gb', name: 'EN' },
{ id: 'de', name: 'DE' },
{ id: 'fr', name: 'FR' },
{ id: 'nl-nl', name: 'NL' },
] satisfies {id: LanguageLocale, name: string}[]
type is still valid and for now there is now simple solution to make nb-NO mandatory to implement
💻 Use Cases
It would it make easy to turn runtime errors ins transpile time errors by TS since this could be found before commiting.
There is a workaround but you need to repeat yourfself and have mulitple definitions. So in the end it's just moving the error away from the place in code to the type definition
type LanguageLocale = "en-gb" | "de" | "fr" | "nl-nl" | "nb-NO";
interface LanguageOption {
id: LanguageLocale;
name: string;
}
const allLanguageLocales: { [K in LanguageLocale]: null } = {
"en-gb": null,
"de": null,
"fr": null,
"nl-nl": null,
"nb-NO": null,
};
type CheckLanguages<T extends LanguageOption[]> = T extends (LanguageOption & { id: keyof typeof allLanguageLocales })[] ? T : never;
const languages = [
{ id: 'en-gb', name: i18n('EN') },
{ id: 'de', name: i18n('DE') },
{ id: 'fr', name: i18n('FR') },
{ id: 'nl-nl', name: i18n('NL') },
// { id: 'nb-NO', name: i18n('NO') }, // Uncomment this line to fix the error
] as const;
type CheckedLanguages = CheckLanguages<typeof languages>;
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
L’issue non indica alcun file sorgente, test o punto di ingresso. Inizia dagli esempi proposti e dal workaround esistente, quindi determina come il sistema dei tipi potrebbe imporre ogni membro di un’unione in un array, incluso Array, senza modificare il JavaScript generato. Il lavoro è completo quando la proposta è specificata e coperta per entrambe le forme di array.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- typescript
- Ambito
- compilers
- Tipo di issue
- Funzionalità
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 25/100