microsoft / microsoft/TypeScript

Array with option allof in definition to tell TS that all options must be implemented from that array

Offen
#56,273 4 Kommentare 2 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Awaiting More Feedback Suggestion
Vorherrschende Sprache
Go
Sterne
111k
Forks
14.4k
Ø Merge
1 T. 19 Std.
Gemergte PRs (30 T.)
117

Beschreibung

🔍 Search Terms

Typescript Define Array type with variations
typescript array mandatory
typescript array with predefined options

✅ Viability Checklist
  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
  • This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
⭐ Suggestion

Typescript should be extended by a list of available options which a type must implement mandatory

type LanguageLocale = "en-gb" | "de" | "fr" | "nl-nl" | "nb-NO"

[
  { id: 'en-gb', name: 'EN' },
  { id: 'de', name: 'DE' },
  { id: 'fr', name: 'FR' },
  { id: 'nl-nl', name: 'NL' },
] satisfies {id: allof LanguageLocale, name: string}[]

here in my suggestion the keyword allof would describe that this array need to implement all options of LanguageLocale.
allof should be only usable together with [] or in case definition is split it should be ignored (e.g. LanguageEntry is used directly somewhere)

type LanguageLocale = "en-gb" | "de" | "fr" | "nl-nl" | "nb-NO"
type LanguageEntry = {id: allO fLanaugeLocale, name: string}
type LanguageEntries = LanguageEntry[]

It should work as well for type Array<T>

📃 Motivating Example

The motivation is to find places in the code where options are missed but mandatory
Imaging a Language Picker and you added a new language.
In the code the following was present.

It have had following data:

type LanguageLocale = "en-gb" | "de" | "fr" | "nl-nl" 
[
  { id: 'en-gb', name: 'EN' },
  { id: 'de', name: 'DE' },
  { id: 'fr', name: 'FR' },
  { id: 'nl-nl', name: 'NL' },
] satisfies {id: LanguageLocale, name: string}[]

so after adding "nb-NO"

type LanguageLocale = "en-gb" | "de" | "fr" | "nl-nl"|"nb-NO"
[
  { id: 'en-gb', name: 'EN' },
  { id: 'de', name: 'DE' },
  { id: 'fr', name: 'FR' },
  { id: 'nl-nl', name: 'NL' },
] satisfies {id: LanguageLocale, name: string}[]

type is still valid and for now there is now simple solution to make nb-NO mandatory to implement

💻 Use Cases

It would it make easy to turn runtime errors ins transpile time errors by TS since this could be found before commiting.

There is a workaround but you need to repeat yourfself and have mulitple definitions. So in the end it's just moving the error away from the place in code to the type definition

type LanguageLocale = "en-gb" | "de" | "fr" | "nl-nl" | "nb-NO";
 
interface LanguageOption {
  id: LanguageLocale;
  name: string;
}
 
const allLanguageLocales: { [K in LanguageLocale]: null } = {
  "en-gb": null,
  "de": null,
  "fr": null,
  "nl-nl": null,
  "nb-NO": null,
};
 
type CheckLanguages<T extends LanguageOption[]> = T extends (LanguageOption & { id: keyof typeof allLanguageLocales })[] ? T : never;
 
const languages = [
  { id: 'en-gb', name: i18n('EN') },
  { id: 'de', name: i18n('DE') },
  { id: 'fr', name: i18n('FR') },
  { id: 'nl-nl', name: i18n('NL') },
  // { id: 'nb-NO', name: i18n('NO') }, // Uncomment this line to fix the error
] as const;
 
type CheckedLanguages = CheckLanguages<typeof languages>;

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Das Issue nennt keine Quelldateien, Tests oder Einstiegspunkte. Beginne mit den vorgeschlagenen Beispielen und dem bestehenden Workaround und ermittle anschließend, wie das Typsystem jedes Element einer Union in einem Array erzwingen könnte, einschließlich Array, ohne das erzeugte JavaScript zu ändern. Als abgeschlossen gilt die Aufgabe, wenn der Vorschlag spezifiziert und für beide Array-Formen abgedeckt ist.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
typescript
Bereich
compilers
Issue-Typ
Feature
Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
25/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.