Suggestion: go-to-definition should go to a base definition if possible.

Open
#21,702 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Stale
Tech stack
typescript
Domain
developer-experience

Research direction

Start by running the provided TypeScript reproduction and checking the existing go-to-definition behavior for the override in class B. Trace the language-service entry point responsible for definition navigation, including the interface case, and verify completion when both cases navigate to the matching member in class A.

Written by the indexing model from the issue text.

Description

Domain: LS: Symbol Navigation In Discussion Suggestion

TypeScript Version: master

Code

class A {
    m() {}
}
class B extends A {
    m() {}
}

Expected behavior:

Go-to-definition on m in class B should go to m in class A. (Same if A were an interface.)

Actual behavior:

I get taken to the beginning of the current identifier.

Dominant language
Go
Stars
111k
Forks
14.4k
Avg merge
1d 19h
Merged PRs (30d)
117

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/TypeScript

All issues in microsoft/TypeScript

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.