Multiple issues while interacting with functions defined on top of one another

オープン
#4,429 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
32/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
停滞
技術スタック
cpp

調査の方向性

Start by reproducing the overlapping-function scenario described in the issue: define two functions at one address, set a tag on the second, navigate to it, and observe view updates during analysis. Trace the affected navigation, tag, and analysis-refresh entry points; done means each action remains associated with the correct function rather than always selecting the first.

索引モデルが issue の本文から書いたものです。

説明

Component: UI Effort: Medium Impact: Medium

Version and Platform (required):

  • Binary Ninja Version: 3.5.4322-dev
  • OS: macOS
  • OS Version: 13.4
  • CPU Architecture: ARM64

Bug Description:
I've been working on a few databases lately that have had multiple functions defined on top of each other, either erroneously or intentionally. Many user actions (such as navigation) will assume there is exactly one function at a given address and will navigate you to the first function, rather than to the function that your user action actually corresponds to.

An example of this is having a tag set on the second function and trying to navigate there. It will send you to the first function instead.

Another example is the view updating during analysis: It'll just refresh your window into the first function, which is exceptionally disorienting.

Since we support overlapping functions as a key feature that differentiates us from competitors like IDA (which, at least the last time I used it professionally, did not handle this in the slightest), we should make sure that this support works and that we aren't accidentally baking bad assumptions into the codebase when we're making changes and bugfixes.

Steps To Reproduce:

  1. Define two functions, one on top of the other.
  2. Perform actions on the second of the two functions and observe all of the places where it's obvious that we assume Highlander rules apply.
  3. ???
  4. PROFIT!

Expected Behavior:
In all cases, if I am performing an action where the data upon which that action is taking place resides in one function, and not another, we should perform that action on the correct function despite the address existing in multiple.

Screenshots:
Somewhat difficult to take screenshots of some of this, but if anyone wants a video or in-person demo, I'm happy to put in the extra work.

主要言語
C++
スター
1.3k
フォーク
298
平均マージ
5日 5時間
マージ済み PR(30日)
19

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Vector35/binaryninja-api のほかの issue

Vector35/binaryninja-api の issue をすべて見る

似ている issue

C++ の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。