Multiple issues while interacting with functions defined on top of one another
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 32/100
- Tipo de issue
- Error
- Claridad
- Bastante claro
- Estado de actividad
- Estancado
- Stack tecnológico
- cpp
- Área
- reverse-engineering
Línea de trabajo
Start by reproducing the overlapping-function scenario described in the issue: define two functions at one address, set a tag on the second, navigate to it, and observe view updates during analysis. Trace the affected navigation, tag, and analysis-refresh entry points; done means each action remains associated with the correct function rather than always selecting the first.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Version and Platform (required):
- Binary Ninja Version: 3.5.4322-dev
- OS: macOS
- OS Version: 13.4
- CPU Architecture: ARM64
Bug Description:
I've been working on a few databases lately that have had multiple functions defined on top of each other, either erroneously or intentionally. Many user actions (such as navigation) will assume there is exactly one function at a given address and will navigate you to the first function, rather than to the function that your user action actually corresponds to.
An example of this is having a tag set on the second function and trying to navigate there. It will send you to the first function instead.
Another example is the view updating during analysis: It'll just refresh your window into the first function, which is exceptionally disorienting.
Since we support overlapping functions as a key feature that differentiates us from competitors like IDA (which, at least the last time I used it professionally, did not handle this in the slightest), we should make sure that this support works and that we aren't accidentally baking bad assumptions into the codebase when we're making changes and bugfixes.
Steps To Reproduce:
- Define two functions, one on top of the other.
- Perform actions on the second of the two functions and observe all of the places where it's obvious that we assume Highlander rules apply.
- ???
- PROFIT!
Expected Behavior:
In all cases, if I am performing an action where the data upon which that action is taking place resides in one function, and not another, we should perform that action on the correct function despite the address existing in multiple.
Screenshots:
Somewhat difficult to take screenshots of some of this, but if anyone wants a video or in-person demo, I'm happy to put in the extra work.
- Lenguaje dominante
- C++
- Estrellas
- 1.3k
- Forks
- 298
- Merge medio
- 5 d 5 h
- PR fusionados (30 d)
- 19
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de Vector35/binaryninja-api
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 88/100
Vector35/binaryninja-api#8540 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
Vector35/binaryninja-api#8516 ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 92/100
Vector35/binaryninja-api#8503 ·
-
normalize time logs from WARP Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
Vector35/binaryninja-api#8446 ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
Vector35/binaryninja-api#8444 ·
Todos los issues de Vector35/binaryninja-api
Issues similares
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 92/100
autowarefoundation/autoware_universe#13413 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
-
automated-analysis bug memory-safety
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 86/100
-
Sensor initialization takes very long when `--initial-sim-time` is set to current UNIX timestamp Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
gazebosim/gz-sensors#662 · 1 comentario ·