Multiple issues while interacting with functions defined on top of one another

Aperta
#4,429 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
32/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
cpp

Direzione di ricerca

Start by reproducing the overlapping-function scenario described in the issue: define two functions at one address, set a tag on the second, navigate to it, and observe view updates during analysis. Trace the affected navigation, tag, and analysis-refresh entry points; done means each action remains associated with the correct function rather than always selecting the first.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Component: UI Effort: Medium Impact: Medium

Version and Platform (required):

  • Binary Ninja Version: 3.5.4322-dev
  • OS: macOS
  • OS Version: 13.4
  • CPU Architecture: ARM64

Bug Description:
I've been working on a few databases lately that have had multiple functions defined on top of each other, either erroneously or intentionally. Many user actions (such as navigation) will assume there is exactly one function at a given address and will navigate you to the first function, rather than to the function that your user action actually corresponds to.

An example of this is having a tag set on the second function and trying to navigate there. It will send you to the first function instead.

Another example is the view updating during analysis: It'll just refresh your window into the first function, which is exceptionally disorienting.

Since we support overlapping functions as a key feature that differentiates us from competitors like IDA (which, at least the last time I used it professionally, did not handle this in the slightest), we should make sure that this support works and that we aren't accidentally baking bad assumptions into the codebase when we're making changes and bugfixes.

Steps To Reproduce:

  1. Define two functions, one on top of the other.
  2. Perform actions on the second of the two functions and observe all of the places where it's obvious that we assume Highlander rules apply.
  3. ???
  4. PROFIT!

Expected Behavior:
In all cases, if I am performing an action where the data upon which that action is taking place resides in one function, and not another, we should perform that action on the correct function despite the address existing in multiple.

Screenshots:
Somewhat difficult to take screenshots of some of this, but if anyone wants a video or in-person demo, I'm happy to put in the extra work.

Lingua principale
C++
Stelle
1.3k
Fork
298
Merge medio
5g 5h
PR unite (30g)
19

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Vector35/binaryninja-api

Tutte le issue di Vector35/binaryninja-api

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.