ionic-team / ionic-team/ionic-framework
Remove ion-toolbar from being captured in screenshots where its appearance doesn't matter
- Ngôn ngữ chính
- TypeScript
- Star
- 52.7k
- Fork
- 13.3k
- Merge trung bình
- 1 ngày 15 giờ
- Pull request đã merge (30 ngày)
- 51
Mô tả
Currently, any time ion-toolbar changes in appearance, [a lot of screenshots](https://github.com/ionic-team/ionic-framework/pull/30371/files) have to be updated.
Most of them are only being updated because they include `ion-toolbar` for labeling the test; the change in them doesn’t matter because the test isn’t meant to verify the look of the toolbar.
The following groups of tests should be updated so that the test does not include the toolbar, since it doesn’t make sense to test the toolbar as part of the screenshot test in them:
- badge-basic
- button
- item
- list-header
- progress-bar
- searchbar
- toast
- toggle
Some of these might have one or two tests where `ion-toolbar` is used in the component they’re testing, but most of them do not, and all of the components listed here have tests that need to be updated to be refocused so they don’t include the `ion-toolbar` in the screenshot capture.
Hướng dẫn đóng góp
Hướng nghiên cứu
Start with the screenshot tests for badge-basic, button, item, list-header, progress-bar, searchbar, toast, and toggle. Find captures that include ion-toolbar only for test labeling, then refocus those tests without the toolbar; done means unrelated screenshots no longer change when ion-toolbar appearance changes.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- typescript
- Lĩnh vực
- frontend, testing
- Loại issue
- Tái cấu trúc
- Độ khó
- 4/5
- Thời gian dự kiến
- 3-5 ngày
- Mức độ hoạt động
- Ít trao đổi
- Độ rõ ràng
- Khá rõ ràng
- Mức phù hợp với người mới
- 52/100