ionic-team / ionic-team/ionic-framework
Remove ion-toolbar from being captured in screenshots where its appearance doesn't matter
- Lenguaje dominante
- TypeScript
- Estrellas
- 52.7k
- Forks
- 13.3k
- Merge medio
- 1 d 15 h
- PR fusionados (30 d)
- 51
Descripción
Currently, any time ion-toolbar changes in appearance, [a lot of screenshots](https://github.com/ionic-team/ionic-framework/pull/30371/files) have to be updated.
Most of them are only being updated because they include `ion-toolbar` for labeling the test; the change in them doesn’t matter because the test isn’t meant to verify the look of the toolbar.
The following groups of tests should be updated so that the test does not include the toolbar, since it doesn’t make sense to test the toolbar as part of the screenshot test in them:
- badge-basic
- button
- item
- list-header
- progress-bar
- searchbar
- toast
- toggle
Some of these might have one or two tests where `ion-toolbar` is used in the component they’re testing, but most of them do not, and all of the components listed here have tests that need to be updated to be refocused so they don’t include the `ion-toolbar` in the screenshot capture.
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.