ionic-team / ionic-team/ionic-framework

Remove ion-toolbar from being captured in screenshots where its appearance doesn't matter

オープン
#30,422 コメント 2 件 リアクション 0 件 担当者 0 名 GitHub で見る
help wanted ionfw-internship-2025 type: feature request
主要言語
TypeScript
スター
52.7k
フォーク
13.3k
平均マージ
1日 15時間
マージ済み PR(30日)
51

説明

Currently, any time ion-toolbar changes in appearance, [a lot of screenshots](https://github.com/ionic-team/ionic-framework/pull/30371/files) have to be updated.
Most of them are only being updated because they include `ion-toolbar` for labeling the test; the change in them doesn’t matter because the test isn’t meant to verify the look of the toolbar.

The following groups of tests should be updated so that the test does not include the toolbar, since it doesn’t make sense to test the toolbar as part of the screenshot test in them:

- badge-basic
- button
- item
- list-header
- progress-bar
- searchbar
- toast
- toggle

Some of these might have one or two tests where `ion-toolbar` is used in the component they’re testing, but most of them do not, and all of the components listed here have tests that need to be updated to be refocused so they don’t include the `ion-toolbar` in the screenshot capture.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。