inducer / inducer/arraycontext

Handling temperature initial guesses

Đang mở
#101 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
Ngôn ngữ chính
Python
Star
9
Fork
11
Merge trung bình
17 giờ 12 phút
Pull request đã merge (30 ngày)
2

Mô tả

In full-on combustion mirgecom, temperature is found via Newton iteration in https://github.com/ecisneros8/pyrometheus. This is expensive, and it's made substantially cheaper/more reliable by the availability of a starting guess (typically, the last temperature). In eager eval, this is easy: the last value can be sent "along for the ride" in the `ConservedVars` and looked at when needed. There are two aspects here:

* So it sits in an array container, but it may not participate in arithmetic. (Realize that it's possible that no meaningful "temperature increments" are being computed, so the array container parts related to temperature initial guesses returned for the ODE RHS are likely `None`. The container arithmetic should be able to take that. Conceivably we could compute those increments, and the arithmetic *might* start making sense... but I'm not sure we want to.) So this is the first question: Do we teach `with_container_arithmetic` about what's needed? How? (Include `Optional` in the field type spec? More arguments like `allow_none=["field1", "field2"]`?)
* The other aspect is that this temperature initial guess needs to be "placeholderized" and propagated into `actx.compile`d code. As long as it's a somewhat normal part of an array container, that happens automatically. (but @mtcam: the "just copy it from the template" mode we discussed likely won't work with lazy, because it won't get "placeholderized" upon entry to a `compile`d function.)

cc @mtcam @kaushikcfd @alexfikl

Hướng dẫn đóng góp

Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.