inducer / inducer/arraycontext

Handling temperature initial guesses

Aberta
#101 0 comentários 0 reações 0 responsáveis Ver no GitHub
Linguagem predominante
Python
Estrelas
9
Forks
11
Merge médio
17h 12min
PRs com merge (30d)
2

Descrição

In full-on combustion mirgecom, temperature is found via Newton iteration in https://github.com/ecisneros8/pyrometheus. This is expensive, and it's made substantially cheaper/more reliable by the availability of a starting guess (typically, the last temperature). In eager eval, this is easy: the last value can be sent "along for the ride" in the `ConservedVars` and looked at when needed. There are two aspects here:

* So it sits in an array container, but it may not participate in arithmetic. (Realize that it's possible that no meaningful "temperature increments" are being computed, so the array container parts related to temperature initial guesses returned for the ODE RHS are likely `None`. The container arithmetic should be able to take that. Conceivably we could compute those increments, and the arithmetic *might* start making sense... but I'm not sure we want to.) So this is the first question: Do we teach `with_container_arithmetic` about what's needed? How? (Include `Optional` in the field type spec? More arguments like `allow_none=["field1", "field2"]`?)
* The other aspect is that this temperature initial guess needs to be "placeholderized" and propagated into `actx.compile`d code. As long as it's a somewhat normal part of an array container, that happens automatically. (but @mtcam: the "just copy it from the template" mode we discussed likely won't work with lazy, because it won't get "placeholderized" upon entry to a `compile`d function.)

cc @mtcam @kaushikcfd @alexfikl

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Direção de pesquisa

Start by reviewing the with_container_arithmetic entry point and the actx.compile placeholderization path, using ConservedVars as the described container context. Define done as a documented design and implementation plan for optional temperature-guess fields, their arithmetic behavior, and propagation through compiled code.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
python
Domínio
tooling
Tipo de issue
Funcionalidade
Dificuldade
5/5
Tempo estimado
Mais de uma semana
Status de atividade
Estagnada
Clareza
Precisa de esclarecimento
Facilidade para iniciantes
25/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.