inducer / inducer/arraycontext

Handling temperature initial guesses

Open
#101 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
9
Forks
11
Avg merge
17h 12m
Merged PRs (30d)
2

Description

In full-on combustion mirgecom, temperature is found via Newton iteration in https://github.com/ecisneros8/pyrometheus. This is expensive, and it's made substantially cheaper/more reliable by the availability of a starting guess (typically, the last temperature). In eager eval, this is easy: the last value can be sent "along for the ride" in the `ConservedVars` and looked at when needed. There are two aspects here:

* So it sits in an array container, but it may not participate in arithmetic. (Realize that it's possible that no meaningful "temperature increments" are being computed, so the array container parts related to temperature initial guesses returned for the ODE RHS are likely `None`. The container arithmetic should be able to take that. Conceivably we could compute those increments, and the arithmetic *might* start making sense... but I'm not sure we want to.) So this is the first question: Do we teach `with_container_arithmetic` about what's needed? How? (Include `Optional` in the field type spec? More arguments like `allow_none=["field1", "field2"]`?)
* The other aspect is that this temperature initial guess needs to be "placeholderized" and propagated into `actx.compile`d code. As long as it's a somewhat normal part of an array container, that happens automatically. (but @mtcam: the "just copy it from the template" mode we discussed likely won't work with lazy, because it won't get "placeholderized" upon entry to a `compile`d function.)

cc @mtcam @kaushikcfd @alexfikl

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the with_container_arithmetic entry point and the actx.compile placeholderization path, using ConservedVars as the described container context. Define done as a documented design and implementation plan for optional temperature-guess fields, their arithmetic behavior, and propagation through compiled code.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.