iLPdev / iLPdev/discMapper

Deprecated: `map.prompt.room` ???

Open
#46 2 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
Lua
Stars
8
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Should we go through and replace `map.prompt.room` with `gmcp.room.info.name` everywhere or define it once and for all at the beginning? It's not a local variable so the user can alter it as intended, but would there ever be a reason to do so? discMapper sets the room name based on what the game sends rather than misidentified text or location as previously.

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the discMapper codebase for map.prompt.room and gmcp.room.info.name, then read the code that sets the room name from game data. Determine whether the prompt value must remain user-editable or can be replaced, and document or implement one consistent choice throughout the mapper.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.