hardbyte / hardbyte/python-can

Add comments for messages

未關閉
#1,663 2 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
enhancement
主要語言
Python
星號
1.6k
分支
697
PR 合併指標
30 天內沒有已合併 PR

描述

### Is your feature request related to a problem? Please describe.
I am using this library to analyze can traces in several formats. Sometimes i would like to add some comments to can messages that are then printed inside an output trace file. This is supported for example by the asc file format.

### Describe the solution you'd like
The class `Message` should get an attribute `comment` by default (e.g. None by default)

### Describe alternatives you've considered
right now i am using some hack to write to the file object inside the writer classes but this is quite unstable when the library changes

### Additional context
I would like to implement this and add it to the reader and writer classes as well but first i would like to get some feedback on this feature request.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。