hardbyte / hardbyte/python-can

Add comments for messages

Aberta
#1,663 2 comentários 0 reações 0 responsáveis Ver no GitHub
enhancement
Linguagem predominante
Python
Estrelas
1.6k
Forks
697
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

### Is your feature request related to a problem? Please describe.
I am using this library to analyze can traces in several formats. Sometimes i would like to add some comments to can messages that are then printed inside an output trace file. This is supported for example by the asc file format.

### Describe the solution you'd like
The class `Message` should get an attribute `comment` by default (e.g. None by default)

### Describe alternatives you've considered
right now i am using some hack to write to the file object inside the writer classes but this is quite unstable when the library changes

### Additional context
I would like to implement this and add it to the reader and writer classes as well but first i would like to get some feedback on this feature request.

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.