hardbyte / hardbyte/python-can

Add comments for messages

未关闭
#1,663 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
enhancement
主要语言
Python
星标
1.6k
派生
697
PR 合并指标
30 天内没有已合并 PR

描述

### Is your feature request related to a problem? Please describe.
I am using this library to analyze can traces in several formats. Sometimes i would like to add some comments to can messages that are then printed inside an output trace file. This is supported for example by the asc file format.

### Describe the solution you'd like
The class `Message` should get an attribute `comment` by default (e.g. None by default)

### Describe alternatives you've considered
right now i am using some hack to write to the file object inside the writer classes but this is quite unstable when the library changes

### Additional context
I would like to implement this and add it to the reader and writer classes as well but first i would like to get some feedback on this feature request.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。