hardbyte / hardbyte/python-can

Add comments for messages

Open
#1,663 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
1.6k
Forks
697
PR merge metrics
No merged PRs in 30d

Description

### Is your feature request related to a problem? Please describe.
I am using this library to analyze can traces in several formats. Sometimes i would like to add some comments to can messages that are then printed inside an output trace file. This is supported for example by the asc file format.

### Describe the solution you'd like
The class `Message` should get an attribute `comment` by default (e.g. None by default)

### Describe alternatives you've considered
right now i am using some hack to write to the file object inside the writer classes but this is quite unstable when the library changes

### Additional context
I would like to implement this and add it to the reader and writer classes as well but first i would like to get some feedback on this feature request.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.