hardbyte / hardbyte/python-can

Replay candump: `MessageSync` (python-can) and `canplayer` (can-utils) behave slightly differently

オープン
#1,646 コメント 2 件 リアクション 0 件 担当者 0 名 GitHub で見る
bug
主要言語
Python
スター
1.6k
フォーク
697
PR マージ指標
30日以内にマージされた PR はありません

説明

Hi,
### Observation:
Regarding the skip parameter `MessageSync` (python-can) and `canplayer` (can-utils) behave slightly differently.

`canplayer -s 1 -I candump.log`
skip gaps in timestamps > 1 second
if skip gap is detected the subsequent CAN msg is sent *instantly*

however

`MessageSync(reader,timestamps=True, skip=1)`
skip gaps in timestamps > 1 second
if skip gap is detected the subsequent CAN msg is sent only *after 1sec*

As a result there is an additional gap of 1sec if I compare both traces.

### Expected behavior
`canplayer` and `python-can` replay stored canlogs exactly the same

### Additional context
I'm not really sure whether this is a bug or a feature.
However I decided to share my experience as I spent quite some time to find the root cause of my problem.
Many thanks ...

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。