hardbyte / hardbyte/python-can

Replay candump: `MessageSync` (python-can) and `canplayer` (can-utils) behave slightly differently

未关闭
#1,646 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
bug
主要语言
Python
星标
1.6k
派生
697
PR 合并指标
30 天内没有已合并 PR

描述

Hi,
### Observation:
Regarding the skip parameter `MessageSync` (python-can) and `canplayer` (can-utils) behave slightly differently.

`canplayer -s 1 -I candump.log`
skip gaps in timestamps > 1 second
if skip gap is detected the subsequent CAN msg is sent *instantly*

however

`MessageSync(reader,timestamps=True, skip=1)`
skip gaps in timestamps > 1 second
if skip gap is detected the subsequent CAN msg is sent only *after 1sec*

As a result there is an additional gap of 1sec if I compare both traces.

### Expected behavior
`canplayer` and `python-can` replay stored canlogs exactly the same

### Additional context
I'm not really sure whether this is a bug or a feature.
However I decided to share my experience as I spent quite some time to find the root cause of my problem.
Many thanks ...

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。