hardbyte / hardbyte/python-can

Replay candump: `MessageSync` (python-can) and `canplayer` (can-utils) behave slightly differently

Abierto
#1,646 2 comentarios 0 reacciones 0 asignados Ver en GitHub
bug
Lenguaje dominante
Python
Estrellas
1.6k
Forks
697
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Hi,
### Observation:
Regarding the skip parameter `MessageSync` (python-can) and `canplayer` (can-utils) behave slightly differently.

`canplayer -s 1 -I candump.log`
skip gaps in timestamps > 1 second
if skip gap is detected the subsequent CAN msg is sent *instantly*

however

`MessageSync(reader,timestamps=True, skip=1)`
skip gaps in timestamps > 1 second
if skip gap is detected the subsequent CAN msg is sent only *after 1sec*

As a result there is an additional gap of 1sec if I compare both traces.

### Expected behavior
`canplayer` and `python-can` replay stored canlogs exactly the same

### Additional context
I'm not really sure whether this is a bug or a feature.
However I decided to share my experience as I spent quite some time to find the root cause of my problem.
Many thanks ...

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.