Remove RetriableStream flush workaround
- 主要言語
- Java
- スター
- 12.1k
- フォーク
- 4k
- 平均マージ
- 2日 17時間
- マージ済み PR(30日)
- 37
説明
In https://github.com/grpc/grpc-java/pull/9360 I added this workaround:
https://github.com/grpc/grpc-java/blob/7c73baa450c87e6a6f767d7451c46ca256e5158a/core/src/main/java/io/grpc/internal/RetriableStream.java#L565-L568
A flush() must always follow a write (but other flushes and calls could be in-between). I tried to flush everywhere but it didn't work at the time. See also #9340. It is possible there were interactions with https://github.com/grpc/grpc-java/issues/9547 which prevented it from working and just trying again may work.
コントリビューションガイド
調査の方向性
Start in core/src/main/java/io/grpc/internal/RetriableStream.java at the workaround around lines 565-568. Read the context of #9340 and #9547, then determine whether the workaround can now be removed while preserving the requirement that a flush follows every write. Done means the workaround is removed and the resulting flush behavior remains correct.
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- java
- 領域
- api
- issue の種類
- リファクタリング
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 35/100