Remove RetriableStream flush workaround
- Lenguaje dominante
- Java
- Estrellas
- 12.1k
- Forks
- 4k
- Merge medio
- 2 d 17 h
- PR fusionados (30 d)
- 37
Descripción
In https://github.com/grpc/grpc-java/pull/9360 I added this workaround:
https://github.com/grpc/grpc-java/blob/7c73baa450c87e6a6f767d7451c46ca256e5158a/core/src/main/java/io/grpc/internal/RetriableStream.java#L565-L568
A flush() must always follow a write (but other flushes and calls could be in-between). I tried to flush everywhere but it didn't work at the time. See also #9340. It is possible there were interactions with https://github.com/grpc/grpc-java/issues/9547 which prevented it from working and just trying again may work.
Guía de contribución
Línea de trabajo
Start in core/src/main/java/io/grpc/internal/RetriableStream.java at the workaround around lines 565-568. Read the context of #9340 and #9547, then determine whether the workaround can now be removed while preserving the requirement that a flush follows every write. Done means the workaround is removed and the resulting flush behavior remains correct.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- java
- Área
- api
- Tipo de issue
- Refactorización
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100