Remove RetriableStream flush workaround
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 12.1k
- Forks
- 4k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 37
Description
In https://github.com/grpc/grpc-java/pull/9360 I added this workaround:
A flush() must always follow a write (but other flushes and calls could be in-between). I tried to flush everywhere but it didn't work at the time. See also #9340. It is possible there were interactions with https://github.com/grpc/grpc-java/issues/9547 which prevented it from working and just trying again may work.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in core/src/main/java/io/grpc/internal/RetriableStream.java at the workaround around lines 565-568. Read the context of #9340 and #9547, then determine whether the workaround can now be removed while preserving the requirement that a flush follows every write. Done means the workaround is removed and the resulting flush behavior remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100