googleapis / googleapis/google-cloud-java
[java-shared-config] Checkstyle shoud set either `failOnViolation` or `failOnError` to `true`
未关闭
type: feature request
- 主要语言
- Java
- 星标
- 2.1k
- 派生
- 1.2k
- 平均合并
- 1 天 23 小时
- 30 天内合并 PR
- 154
描述
Currently, both `failOnViolation` and `failOnError` are set (https://github.com/googleapis/java-shared-config/blob/main/pom.xml#L649,L651).
The way I am reading checkstyle documentation, they are more either/or -- either fail before logging or log and then fail: https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html.
Thanks @elefeint for pointing this out.
贡献指南
评估
这个 Issue 还没有评估数据。