googleapis / googleapis/google-cloud-java
[java-shared-config] Checkstyle shoud set either `failOnViolation` or `failOnError` to `true`
Ouverte
type: feature request
- Langage dominant
- Java
- Étoiles
- 2.1k
- Forks
- 1.2k
- Merge moyen
- 1 j 23 h
- PR mergées (30 j)
- 154
Description
Currently, both `failOnViolation` and `failOnError` are set (https://github.com/googleapis/java-shared-config/blob/main/pom.xml#L649,L651).
The way I am reading checkstyle documentation, they are more either/or -- either fail before logging or log and then fail: https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html.
Thanks @elefeint for pointing this out.
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.