googleapis / googleapis/google-cloud-java
[java-shared-config] Checkstyle shoud set either `failOnViolation` or `failOnError` to `true`
Offen
type: feature request
- Vorherrschende Sprache
- Java
- Sterne
- 2.1k
- Forks
- 1.2k
- Ø Merge
- 1 T. 23 Std.
- Gemergte PRs (30 T.)
- 154
Beschreibung
Currently, both `failOnViolation` and `failOnError` are set (https://github.com/googleapis/java-shared-config/blob/main/pom.xml#L649,L651).
The way I am reading checkstyle documentation, they are more either/or -- either fail before logging or log and then fail: https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html.
Thanks @elefeint for pointing this out.
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.