googleapis / googleapis/google-cloud-java
[java-shared-config] Checkstyle shoud set either `failOnViolation` or `failOnError` to `true`
Aperta
type: feature request
- Lingua principale
- Java
- Stelle
- 2.1k
- Fork
- 1.2k
- Merge medio
- 1g 23h
- PR unite (30g)
- 154
Descrizione
Currently, both `failOnViolation` and `failOnError` are set (https://github.com/googleapis/java-shared-config/blob/main/pom.xml#L649,L651).
The way I am reading checkstyle documentation, they are more either/or -- either fail before logging or log and then fail: https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html.
Thanks @elefeint for pointing this out.
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.